From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122641 invoked by alias); 9 Jan 2017 17:29:23 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 122631 invoked by uid 89); 9 Jan 2017 17:29:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=UD:hint, licensing, prep, Bastian X-HELO: out1-smtp.messagingengine.com Received: from out1-smtp.messagingengine.com (HELO out1-smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jan 2017 17:29:12 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id DCFDD20FC9 for ; Mon, 9 Jan 2017 12:29:10 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Mon, 09 Jan 2017 12:29:10 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-173-196-32.range86-173.btcentralplus.com [86.173.196.32]) by mail.messagingengine.com (Postfix) with ESMTPA id 8781F2418A for ; Mon, 9 Jan 2017 12:29:10 -0500 (EST) Subject: Re: [ITP] gambas3 To: cygwin-apps@cygwin.com References: From: Jon Turney Message-ID: Date: Mon, 09 Jan 2017 17:29:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00004.txt.bz2 On 09/01/2017 13:23, Bastian Germann wrote: > Hi, > > I have updated the pending gambas3 package to version 3.9.2. > > Some patches from version 3.9.1 are included in mainline and there is a > new subpackage gambas3-gb-db-odbc now. Nothing else changed regarding > the packaging. Thanks for taking this on, and sorry for taking so long to look at it. A few comments: * It looks like you are using an older cygport version to build your x86 packages, as it's still generating setup.hint files, please update when you can) * The cygport file (possibly) contains some CC-BY-SA licensed content. This probably bears remarking on, but since we have no policy on the licensing of the contents of the source package, apart from the upstream source itself, I guess this is ok. * 'cygport gambas3.cygport prep' says > *** Info: applying patch 1: > patching file gb.db.odbc/src/main.c > patch unexpectedly ends in middle of line > Hunk #9 succeeded at 2765 with fuzz 1. Is this expected? (some artefact of the way cygport is testing the patch?) Apart from that, it looks good to me.