From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109617 invoked by alias); 29 Oct 2017 17:26:04 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 109436 invoked by uid 89); 29 Oct 2017 17:26:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Hx-languages-length:893, Hx-spam-relays-external:ESMTPA, HContent-Transfer-Encoding:8bit X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 29 Oct 2017 17:26:02 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id AFD9021096 for ; Sun, 29 Oct 2017 13:26:00 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Sun, 29 Oct 2017 13:26:00 -0400 X-ME-Sender: Received: from [192.168.1.102] (host86-179-113-201.range86-179.btcentralplus.com [86.179.113.201]) by mail.messagingengine.com (Postfix) with ESMTPA id 59B1A7E13B for ; Sun, 29 Oct 2017 13:26:00 -0400 (EDT) Subject: Re: setup with experimental libsolv-based dependency solving To: cygwin-apps@cygwin.com References: <21eaf4d9-8014-bff3-64c1-eace55132a8b@cornell.edu> <990e3641-5624-ecee-8b1c-0622041baf48@cornell.edu> From: Jon Turney Message-ID: Date: Sun, 29 Oct 2017 17:26:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <990e3641-5624-ecee-8b1c-0622041baf48@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-10/txt/msg00163.txt.bz2 On 28/10/2017 13:31, Ken Brown wrote: > On 10/27/2017 3:52 PM, Ken Brown wrote: >> On 10/27/2017 2:57 PM, Ken Brown wrote: >>> On 10/25/2017 3:18 PM, Jon Turney wrote: >>>> >>>> This has a lot of internal changes, so could use some wider testing. >>>> Please test. >>> >>> I've just discovered a serious bug.  When installing from a local >>> directory that either doesn't exist or isn't a valid repository, >>> setup doesn't correctly read/write the installed file database >>> (/etc/setup/installed.db). >> >> I *think* the problem is that packagedb::read is never called.  Since >> do_local_dir returns false, LocalDirPage::OnNext takes us directly to >> the chooser.  This means that do_ini_thread never gets to the line >> that calls db.read. Yeah, my mistake. > I just submitted two patches that seem to fix this. Thanks.