From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117825 invoked by alias); 2 May 2017 19:29:56 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 117809 invoked by uid 89); 2 May 2017 19:29:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f42.google.com Received: from mail-wm0-f42.google.com (HELO mail-wm0-f42.google.com) (74.125.82.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 19:29:54 +0000 Received: by mail-wm0-f42.google.com with SMTP id u65so123795738wmu.1 for ; Tue, 02 May 2017 12:29:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=zUMm9oIHs3aJWaFrYyXA8GfGYeuAPlRyulDewTEPafI=; b=Af6Y0tEEYebQntPbq3BCnM+3SHo17epKgy5j/iKN3/IqNtURnSENA3pytepUzAcGPp WPF8nTppAMShQ/F03jiVn4nDBM9lpyMx2urNYtBsCg3pz4jDVjqtWAHLmvnAIcy/5QP4 rSQflchQQoQm/W8tlETEQ5N1T4uK8S3cWNNSIWe4nqnm1LT9+tMX+huWFh9HXXbJbFce GiTIvjNVQZw/c3jLUBz9/DsB3hQD6cGKxLdDGj3GfgScjm09MSeEUtVorBad1Tr868kF 7bKY+HslR4S6h9w504GFvONhs+2M5y2ns/k2EWBkD7Pt2rFYK/TRyhwI7lTzF3kfDS9X HaSQ== X-Gm-Message-State: AN3rC/49U02yphnxdI9Hg6If/tHFC0uMSreDQSAIcDg8Rofp0y5SCTvz BvwqAOnJhrPXbw== X-Received: by 10.25.212.19 with SMTP id l19mr10318677lfg.169.1493753394179; Tue, 02 May 2017 12:29:54 -0700 (PDT) Received: from [192.168.1.117] (tb213-185-244-58.cust.teknikbyran.com. [213.185.244.58]) by smtp.googlemail.com with ESMTPSA id r22sm3329712ljd.54.2017.05.02.12.29.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 May 2017 12:29:52 -0700 (PDT) Subject: Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY) To: Jon Turney , cygwin-apps@cygwin.com References: <20170428121205.12240-1-jon.turney@dronecode.org.uk> <20170428121205.12240-12-jon.turney@dronecode.org.uk> <3d79b33e-e067-c1df-9b90-084fb10dd272@dronecode.org.uk> <9452ab7f-986c-2394-8c24-6208e042787e@dronecode.org.uk> <506da115-b976-fdb2-bf1b-cec6addfbbbb@dronecode.org.uk> <0b6ab083-d470-c940-5557-d33be5c523cb@gmail.com> <664411e6-ac32-ab77-1b62-72bafc8bacd8@dronecode.org.uk> From: =?UTF-8?Q?=c3=85ke_Rehnman?= Message-ID: Date: Tue, 02 May 2017 19:29:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <664411e6-ac32-ab77-1b62-72bafc8bacd8@dronecode.org.uk> Content-Type: multipart/mixed; boundary="------------55855D699C75694E7FAA099E" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00020.txt.bz2 This is a multi-part message in MIME format. --------------55855D699C75694E7FAA099E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 783 Hi, >> One thought though, why not let wininet take care of file:// URL's as >> well? Or actually don't try to parse the url string at all and just pass >> it down to NETIO_IE5 unfiltered? The advantage is setup would be able to > > I'd be happy to look at a separate patch to do this. See proposed incremental patch. Have a look, give me your thoughts. > >> handle what ever protocols wininet has. Also letting wininet taking care >> of file:// url's would let the user install from a local network > > I'm pretty sure I've done that in the past, so I think it already > works. The form of file: URL required might not be strictly correct, > though, (I think file:////server/pathname/ ?) Seem to work with \\server\share_name\path or //server/share_name/path now anyway /Ake --------------55855D699C75694E7FAA099E Content-Type: text/plain; charset=UTF-8; name="0001-Use-wininet-for-file-protocol.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Use-wininet-for-file-protocol.patch" Content-length: 2339 RnJvbSA0ZThhOTVlNTliZjc2MWJjNGQwYmNjNGJhM2VjMDQyNDAxMDczYjU0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBa2UgUmVobm1hbiA8 YWtlLnJlaG5tYW4gYXQgZ21haWwuY29tPgpEYXRlOiBUdWUsIDIgTWF5IDIw MTcgMjA6NTU6MDcgKzAyMDAKU3ViamVjdDogW1BBVENIIDEvMV0gVXNlIHdp bmluZXQgZm9yICJmaWxlOi8vIiBwcm90b2NvbC4gVXNlIE5ldElPX0ZpbGUg Zm9yCiB1bmtub3duIHByb3RvY29scy4KCi0tLQogbmV0aW8uY2MgICAgfCAx MCArKysrKystLS0tCiBuaW8tZmlsZS5jYyB8ICA3IC0tLS0tLS0KIDIgZmls ZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9uZXRpby5jYyBiL25ldGlvLmNjCmluZGV4IGNmNjM0 YzEuLjA3ZWUyMTcgMTAwNjQ0Ci0tLSBhL25ldGlvLmNjCisrKyBiL25ldGlv LmNjCkBAIC0xMjYsNyArMTI2LDcgQEAgTmV0SU86Om9wZW4gKGNoYXIgY29u c3QgKnVybCwgYm9vbCBjYWNoYWJsZSkKIHsKICAgTmV0SU8gKnJ2ID0gMDsK ICAgZW51bQotICB7IGh0dHAsIGh0dHBzLCBmdHAsIGZ0cHMsIGZpbGUgfQor ICB7IGh0dHAsIGh0dHBzLCBmdHAsIGZ0cHMsIGZpbGUsIHVuayB9CiAgIHBy b3RvOwogICBpZiAoc3RybmNtcCAodXJsLCAiaHR0cDovLyIsIDcpID09IDAp CiAgICAgcHJvdG8gPSBodHRwOwpAQCAtMTM2LDEwICsxMzYsMTIgQEAgTmV0 SU86Om9wZW4gKGNoYXIgY29uc3QgKnVybCwgYm9vbCBjYWNoYWJsZSkKICAg ICBwcm90byA9IGZ0cDsKICAgZWxzZSBpZiAoc3RybmNtcCAodXJsLCAiZnRw czovLyIsIDcpID09IDApCiAgICAgcHJvdG8gPSBmdHBzOwotICBlbHNlCisg IGVsc2UgaWYgKHN0cm5jbXAgKHVybCwgImZpbGU6Ly8iLCA3KSA9PSAwKQog ICAgIHByb3RvID0gZmlsZTsKKyAgZWxzZQorICAgIHByb3RvID0gdW5rOwog Ci0gIGlmIChwcm90byA9PSBmaWxlKQorICBpZiAocHJvdG8gPT0gdW5rKQog ICAgIHJ2ID0gbmV3IE5ldElPX0ZpbGUgKHVybCk7CiAgIGVsc2UgaWYgKG5l dF9tZXRob2QgPT0gSURDX05FVF9JRTUpCiAgICAgcnYgPSBuZXcgTmV0SU9f SUU1ICh1cmwsIGZhbHNlLCBjYWNoYWJsZSk7CkBAIC0xNTcsNyArMTU5LDcg QEAgTmV0SU86Om9wZW4gKGNoYXIgY29uc3QgKnVybCwgYm9vbCBjYWNoYWJs ZSkKIAljYXNlIGZ0cDoKIAkgIHJ2ID0gbmV3IE5ldElPX0ZUUCAodXJsKTsK IAkgIGJyZWFrOwotCWNhc2UgZmlsZToKKwljYXNlIHVuazoKIAkgIHJ2ID0g bmV3IE5ldElPX0ZpbGUgKHVybCk7CiAJICBicmVhazsKIAlkZWZhdWx0Ogpk aWZmIC0tZ2l0IGEvbmlvLWZpbGUuY2MgYi9uaW8tZmlsZS5jYwppbmRleCBl NjlmMWZmLi5jMzAyNjE2IDEwMDY0NAotLS0gYS9uaW8tZmlsZS5jYworKysg Yi9uaW8tZmlsZS5jYwpAQCAtMzUsMTMgKzM1LDYgQEAgTmV0SU8gKFB1cmwp CiAgICAgewogICAgICAgZmlsZV9zaXplID0gZ2V0X2ZpbGVfc2l6ZSAoc3Rk OjpzdHJpbmcoImZpbGU6Ly8iKSArIHBhdGgpOwogICAgIH0KLSAgZWxzZQot ICAgIHsKLSAgICAgIGNvbnN0IGNoYXIgKmVyciA9IHN0cmVycm9yIChlcnJu byk7Ci0gICAgICBpZiAoIWVycikKLQllcnIgPSAiKHVua25vd24gZXJyb3Ip IjsKLSAgICAgIG5vdGUgKE5VTEwsIElEU19FUlJfT1BFTl9SRUFELCBwYXRo LCBlcnIpOwotICAgIH0KIH0KIAogTmV0SU9fRmlsZTo6fk5ldElPX0ZpbGUg KCkKLS0gCjIuMTIuMgoK --------------55855D699C75694E7FAA099E--