From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT
Date: Tue, 05 Dec 2017 12:58:00 -0000 [thread overview]
Message-ID: <c32b66ca-2a51-2efd-7835-9dc11f7bd33b@dronecode.org.uk> (raw)
In-Reply-To: <20171204155855.9484-1-kbrown@cornell.edu>
On 04/12/2017 15:58, Ken Brown wrote:
> ---
> site.cc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/site.cc b/site.cc
> index 641a6bb..64e56a8 100644
> --- a/site.cc
> +++ b/site.cc
> @@ -759,7 +759,9 @@ bool SitePage::OnMessageCmd (int id, HWND hwndctl, UINT code)
> {
> case IDC_EDIT_USER_URL:
> {
> - // FIXME: Make Enter here cause an ADD, not a NEXT.
> + // Set the default pushbutton to ADD if the user is entering text.
> + if (code == EN_CHANGE)
> + SendMessage (GetHWND (), DM_SETDEFID, (WPARAM) IDC_BUTTON_ADD_URL, 0);
> break;
> }
> case IDC_URL_LIST:
>
Very nice. That fixme has been there since 2002 (and the bug probably
longer...)
I thought perhaps we might need to reset the default control if the
focus is moved to another control after IDC_EDIT_USER_URL so that enter
works correctly then, but that doesn't seem to be the case.
Please apply.
The search textbox on the package chooser page needs the same fix.
next prev parent reply other threads:[~2017-12-05 12:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 15:59 Ken Brown
2017-12-05 12:58 ` Jon Turney [this message]
2017-12-05 16:03 ` Ken Brown
2017-12-05 17:32 ` Ken Brown
2017-12-07 18:35 ` Jon Turney
2017-12-07 20:46 ` Ken Brown
2017-12-08 4:55 ` Brian Inglis
2017-12-08 14:47 ` Ken Brown
2017-12-08 15:55 ` Jon Turney
2017-12-08 15:48 ` Jon Turney
2017-12-08 16:14 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c32b66ca-2a51-2efd-7835-9dc11f7bd33b@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).