From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) by sourceware.org (Postfix) with ESMTPS id 8528B3858032 for ; Wed, 19 Jan 2022 03:51:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8528B3858032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=SystematicSw.ab.ca Authentication-Results: sourceware.org; spf=none smtp.mailfrom=systematicsw.ab.ca Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id 9q8Onbv7C5Rf1A20nnWLcr; Wed, 19 Jan 2022 03:51:53 +0000 Received: from [192.168.1.105] ([68.147.0.90]) by cmsmtp with ESMTP id A20mnE88zviGhA20mnZcli; Wed, 19 Jan 2022 03:51:53 +0000 X-Authority-Analysis: v=2.4 cv=IaOU5Ema c=1 sm=1 tr=0 ts=61e78ad9 a=T+ovY1NZ+FAi/xYICV7Bgg==:117 a=T+ovY1NZ+FAi/xYICV7Bgg==:17 a=IkcTkHD0fZMA:10 a=vKebfVIyAAAA:8 a=FP58Ms26AAAA:8 a=3u8C83o-MhYDkUuBlyMA:9 a=QEXdDO2ut3YA:10 a=diTawE-iSxgA:10 a=B4R09VMvA1IA:10 a=n2eEs4sum_sr8PAT1Mgn:22 Message-ID: Date: Tue, 18 Jan 2022 20:51:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Reply-To: cygwin-apps@cygwin.com Subject: Re: [ITP] biosig [was: Re: newcomer issues when packaging biosig, stimfit, etc.] Content-Language: en-CA From: Brian Inglis To: cygwin-apps@cygwin.com References: <99eff890-3d7f-7fa9-1f42-d8d611b92ded@gmail.com> <44c5a1de-dbfe-625d-8ff8-049d8047277e@gmail.com> <8e1cdac3-b217-faa6-d0a0-8f8a61c6d2a3@gmail.com> <3a18d77a-0339-0702-fdab-ff40cac8d25a@SystematicSw.ab.ca> <93d44ea0-a2d6-a71e-9729-59551c2c32ed@gmail.com> <00a12f63-2725-8220-d761-fe93711e04d5@gmail.com> <87ee584tlv.fsf@Rainer.invalid> <91c9b104-69b2-01b5-9099-3af74a8522ff@gmail.com> <9e20944e-1fdd-7928-9c3b-84f5b907f011@SystematicSw.ab.ca> <9aa0ab98-2270-0593-df1f-28bad20420f2@gmail.com> <39e25058-5c5c-e2a9-7452-0a5b90ceee1e@SystematicSw.ab.ca> Organization: Systematic Software In-Reply-To: <39e25058-5c5c-e2a9-7452-0a5b90ceee1e@SystematicSw.ab.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfAFji1IbTpGH8leyiMdV9PA/WYCEBCXFQ4sDCWfd/rQNK6/jEdS5EuaeToyi1qyHzDm/Mf4yHVxuVSWKu1mYycd5ZVMEdKKQ1HwoYDz7FuMV/22GDc0H mSiLUDrMtaQ3OWMAxF6ByENOo67sCZnj64Yi8mVaywqzjDQ/d7VhhxjbNsMlaHa35EdXDzZ4luEtDD4Lw2Xzy4c+5j7VeEte/ds= X-Spam-Status: No, score=-1159.2 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2022 03:51:55 -0000 On 2022-01-18 15:56, Brian Inglis wrote: > On 2022-01-18 14:50, Alois Schlögl wrote: >> Am 1/18/22 um 06:32 schrieb Brian Inglis: >>> On 2022-01-17 14:44, Alois Schlögl wrote: >>>> Am 1/15/22 um 21:44 schrieb Achim Gratz: >>>>> Marco Atzeri writes: >>> >>>>>> add DIFF_EXCLUDES="Makefile" to avoid the artifact >>> >>>>> DISTCLEANFILES would be more appropriate it seems. >>> >>> DISTCLEANFILES is deleted immediately after downloading and unpacking >>> the *UPSTREAM* source: >>> >>>     https://cygwin.github.io/cygport/src_prep_cygpart.html#robo112 >>> >>> "A list of files to be deleted immediately upon unpacking sources, >>> relative to $S. This is intended to be used with >>> buildsystem-generated files which are incorrectly included in the >>> source tarball." >>> >>>> I tried this (see attachment), but I'm not sure this is what you meant. >>> >>> DIFF_EXCLUDES is a list of files generated in $S not automatically >>> excluded from the source package: >>> >>>     https://cygwin.github.io/cygport/pkg_pkg_cygpart.html#robo384 >>> >>> "A list of file names, directory names, or glob patterns in $S which >>> will be excluded when creating the .src.patch file. This should be >>> used for files automatically generated in $S to avoid polluting the >>> patch. >>> NOTE >>> Files generated by various buildsystem infrastructures, such as >>> autoconf, automake, gettext, and libtool are already excluded >>> automatically and need not be listed here." > >>> Add to DIFF_EXCLUDES the names of any files you see after the output >>> header: >>> >>>>>> Creating source patches > >> Ok, thanks for these clear hints. I've now added these files as >> suggested. The revised version is attached. >> Moreover, I've removed (commented) all aspects for building of >> python-biosig bindings, in order not to delay the inclusion of Biosig >> in Cygwin. >> Is there anything else that need to be considered ? > > CATEGORY is a *space* separated list in quotes. > > Before SRC_URI and PATCH_URI normally comes: > >     HOMEPAGE=https://sourceforge.net/projects/biosig/files/ > > you don't need to add quotes for nonspaced strings. > > You may also test your cygport and any other source patches and files > you require by creating and committing them into a local git repo named > the same as the package (preferably all lower case) and pushing to the > git-cygwin-packages playground repo and branch: > > git push --set-upstream ssh://cygwin/git/cygwin-packages/playground.git > playground -f > > which will submit the build to the Cygwin GitHub Action CI and print the > link for you to monitor the CI job, view the build logs for noarch, x86, > and x86_64, and download them. I just noticed that your description is badly wrapped: to avoid this, run the text through fmt or your editor equivalent (e.g. gvim :set tw=72 then gqq to wrap the lines) and paste between the quotes after DESCRIPTION="... ...". Forgot to mention BUILD_REQUIRES which lists all the packages and libraries which need installed to build the package(s) using cygport. From your README for Debian, on Cygwin those packages would probably be: BUILD_REQUIRES="libtinyxml2-devel octave-devel python-devel" BUILD_REQUIRES+=" gawk python-numpy python3-numpy R" and your runtime dependencies should be reported by cygport at the end of the packaging stage as: >>> biosig requires: cygwin libtinyxml2_6 octave-nan octave-tsa R If any are missing, you may add them using REQUIRES similar to BUILD_REQUIRES, however specifying all the packages with REQUIRES results in confusing duplication in cygport output and the setup.ini biosig requires: line entry. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in binary units and prefixes, physical quantities in SI.]