From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29273 invoked by alias); 7 Feb 2018 18:51:34 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 29261 invoked by uid 89); 7 Feb 2018 18:51:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=H*F:D*ab.ca, Canada, HContent-Transfer-Encoding:8bit X-HELO: smtp-out-no.shaw.ca Received: from smtp-out-no.shaw.ca (HELO smtp-out-no.shaw.ca) (64.59.134.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Feb 2018 18:51:32 +0000 Received: from [192.168.1.100] ([24.64.240.204]) by shaw.ca with ESMTP id jUobeZjN17GjajUocexxTe; Wed, 07 Feb 2018 11:51:30 -0700 X-Authority-Analysis: v=2.3 cv=I59Luuog c=1 sm=1 tr=0 a=MVEHjbUiAHxQW0jfcDq5EA==:117 a=MVEHjbUiAHxQW0jfcDq5EA==:17 a=N659UExz7-8A:10 a=3pt1mwMbZFgOV6zd40sA:9 a=pILNOxqGKmIA:10 Reply-To: Brian.Inglis@SystematicSw.ab.ca Subject: Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's To: cygwin-apps@cygwin.com References: <59D90AF8D70E9740907BACDE2BCB520836E4AA63@RESW102.resdom01.local> <20180206142012.GB30794@calimero.vinschen.de> <80645451-e2d6-56bf-87c4-c02ac801f201@maxrnd.com> <29e2c298-107a-eb7e-31a9-0b937a7d95db@redhat.com> From: Brian Inglis Message-ID: Date: Wed, 07 Feb 2018 18:51:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <29e2c298-107a-eb7e-31a9-0b937a7d95db@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfHxTCRQ36AQocRmHKg4VzxuIuxJ8omG8hTATMcB2tbNVKrVsUQa+/VMIxJ4Px3J9v4VgqvqMogCmvjQm1DC4iY1NBHKi0DNEw/pIcDYxIS4oRITzRlcq Ylezhuu5N3Obp8nCpcP7/u4Z1SgmOYrAty8f+nV2sCCPkagTCIIvQbO0uoouvifKpP3PfYQNZ5jKKg== X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00012.txt.bz2 On 2018-02-07 08:38, Eric Blake wrote: > On 02/07/2018 01:29 AM, Mark Geisert wrote: >> I don't have libtirpc in git so I'm submitting a text patch.  Sorry for any >> inconvenience.  This is Cygwin-specific and against src/bindresvport.c of >> libtirpc 1.0.1.  Unsure if it ought to go upstream; appreciate input on that. >> Thanks much, >> >> ..mark >> >> --------8<-------- >> 35a36,38 >>  > /* On Cygwin prefer Cygwin's bindresvport{,_sa}() to portable version here */ > > An ed-script diff is practically useless; without context, it is too easy to > misapply the patch if the file has been edited differently in the meantime.  > ALWAYS use 'diff -u' (what git does by default) or 'diff -c' when generating a > patch, so that it has proper context. Also mandatory to add -p, --show-c-function for patches, and in general for directory or recursive patch diffs -N, --new-file so new files are diffed as if against an empty file; --strip-trailing-cr is useful if some files may have CRs. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada