From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52175 invoked by alias); 18 Oct 2017 15:57:21 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 51597 invoked by uid 89); 18 Oct 2017 15:57:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:3101 X-HELO: limerock03.mail.cornell.edu Received: from limerock03.mail.cornell.edu (HELO limerock03.mail.cornell.edu) (128.84.13.243) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Oct 2017 15:57:20 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v9IFvHoT020683 for ; Wed, 18 Oct 2017 11:57:18 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v9IFvGbS008109 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Wed, 18 Oct 2017 11:57:17 -0400 Subject: Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP) To: cygwin-apps@cygwin.com References: <20170531105015.162228-1-jon.turney@dronecode.org.uk> <488ba627-de58-ddc7-7f69-696adae76b8a@cornell.edu> <9bcf50cf-81bc-c9d1-3ac3-b7e1a3522045@dronecode.org.uk> <5441628f-a99a-1611-616a-da98ea9a0e12@cornell.edu> <7044db65-8b6e-6bf6-a079-99397917ce43@cornell.edu> <8e655423-ef53-3aeb-3d6c-de5021d3bd87@dronecode.org.uk> <5e74cacd-3153-1561-3cd2-5ece0e35a2d2@cornell.edu> <003a8566-ad2b-a962-725a-4384fd5e4c64@cornell.edu> <02e7c6e5-3f7b-5e43-1557-8031b7bb1535@cornell.edu> From: Ken Brown Message-ID: Date: Wed, 18 Oct 2017 15:57:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <02e7c6e5-3f7b-5e43-1557-8031b7bb1535@cornell.edu> Content-Type: multipart/mixed; boundary="------------3E96C5175C6A98660DF5A1CF" X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00071.txt.bz2 This is a multi-part message in MIME format. --------------3E96C5175C6A98660DF5A1CF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 450 On 10/18/2017 11:28 AM, Ken Brown wrote: > Similar considerations apply to the other public member functions of > SolvableVersion.  So my inclination is to go with something like my > patch... ...with perhaps one tweak. Maybe we should test 'id' rather than 'pool', since id being 0 is what's used elsewhere to characterize the empty package. And if id != 0 but pool == 0, there's a bug that we want to catch. Revised patch attached. Ken --------------3E96C5175C6A98660DF5A1CF Content-Type: text/plain; charset=UTF-8; name="0001-Extend-the-SolvableVersion-member-functions-to-the-e.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Extend-the-SolvableVersion-member-functions-to-the-e.pa"; filename*1="tch" Content-length: 3681 RnJvbSA5NDhkYjA5MTgwNzY1ZDg5NjM5YjYzZTM3YTk4ZDM4MDZiZjE5OWQ1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGti cm93bkBjb3JuZWxsLmVkdT4KRGF0ZTogVHVlLCAxNyBPY3QgMjAxNyAwODox Mjo0OCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEV4dGVuZCB0aGUgU29sdmFi bGVWZXJzaW9uIG1lbWJlciBmdW5jdGlvbnMgdG8gdGhlIGVtcHR5CiBwYWNr YWdlCgpDdXJyZW50bHkgc29tZSBvZiB0aGVzZSBmdW5jdGlvbnMgY2F1c2Ug Y3Jhc2hlcyB3aGVuIHRoZSBwYWNrYWdlIGlzCmVtcHR5IGJlY2F1c2UgdGhl IGxpYnNvbHYgZnVuY3Rpb24gcG9vbF9pZDJzb2x2YWJsZSB1bmNvbmRpdGlv bmFsbHkKZGVyZWZlcmVuY2VzIGl0cyBmaXJzdCBhcmd1bWVudCAoJ3Bvb2wn KS4KLS0tCiBsaWJzb2x2LmNjIHwgMTYgKysrKysrKysrKysrKysrLQogMSBm aWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9saWJzb2x2LmNjIGIvbGlic29sdi5jYwppbmRleCA3 OGU3M2E4Li4yODlmMTljIDEwMDY0NAotLS0gYS9saWJzb2x2LmNjCisrKyBi L2xpYnNvbHYuY2MKQEAgLTc1LDYgKzc1LDggQEAgUmVsSWQyT3BlcmF0b3Io SWQgaWQpCiBjb25zdCBzdGQ6OnN0cmluZwogU29sdmFibGVWZXJzaW9uOjpO YW1lICgpIGNvbnN0CiB7CisgIGlmICghaWQpCisgICAgcmV0dXJuICIiOwog ICBTb2x2YWJsZSAqc29sdmFibGUgPSBwb29sX2lkMnNvbHZhYmxlKHBvb2ws IGlkKTsKICAgcmV0dXJuIHN0ZDo6c3RyaW5nKHBvb2xfaWQyc3RyKHBvb2ws IHNvbHZhYmxlLT5uYW1lKSk7CiB9CkBAIC04Miw2ICs4NCw4IEBAIFNvbHZh YmxlVmVyc2lvbjo6TmFtZSAoKSBjb25zdAogY29uc3Qgc3RkOjpzdHJpbmcK IFNvbHZhYmxlVmVyc2lvbjo6Q2Fub25pY2FsX3ZlcnNpb24oKSBjb25zdAog eworICBpZiAoIWlkKQorICAgIHJldHVybiAiIjsKICAgU29sdmFibGUgKnNv bHZhYmxlID0gcG9vbF9pZDJzb2x2YWJsZShwb29sLCBpZCk7CiAgIHJldHVy biBzdGQ6OnN0cmluZyhwb29sX2lkMnN0cihwb29sLCBzb2x2YWJsZS0+ZXZy KSk7CiB9CkBAIC04OSw2ICs5Myw4IEBAIFNvbHZhYmxlVmVyc2lvbjo6Q2Fu b25pY2FsX3ZlcnNpb24oKSBjb25zdAogcGFja2FnZV90eXBlX3QKIFNvbHZh YmxlVmVyc2lvbjo6VHlwZSAoKSBjb25zdAogeworICBpZiAoIWlkKQorICAg IHJldHVybiBwYWNrYWdlX2JpbmFyeTsKICAgU29sdmFibGUgKnNvbHZhYmxl ID0gcG9vbF9pZDJzb2x2YWJsZShwb29sLCBpZCk7CiAgIGlmIChzb2x2YWJs ZS0+YXJjaCA9PSBBUkNIX1NSQykKICAgICByZXR1cm4gcGFja2FnZV9zb3Vy Y2U7CkBAIC0xMTIsNiArMTE4LDkgQEAgU29sdmFibGVWZXJzaW9uOjpvYnNv bGV0ZXMoKSBjb25zdAogY29uc3QgUGFja2FnZURlcGVuZHMKIFNvbHZhYmxl VmVyc2lvbjo6ZGVwbGlzdChJZCBrZXluYW1lKSBjb25zdAogeworICBzdGF0 aWMgUGFja2FnZURlcGVuZHMgZW1wdHlfcGFja2FnZTsKKyAgaWYgKCFpZCkK KyAgICByZXR1cm4gZW1wdHlfcGFja2FnZTsKICAgU29sdmFibGUgKnNvbHZh YmxlID0gcG9vbF9pZDJzb2x2YWJsZShwb29sLCBpZCk7CiAKICAgUXVldWUg cTsKQEAgLTE0NywxMyArMTU2LDE0IEBAIFNvbHZhYmxlVmVyc2lvbjo6ZGVw bGlzdChJZCBrZXluYW1lKSBjb25zdAogICAgIH0KIAogICAvLyBvdGhlcndp c2UsIHJldHVybiBhbiBlbXB0eSBkZXBlbmRzIGxpc3QKLSAgc3RhdGljIFBh Y2thZ2VEZXBlbmRzIGVtcHR5X3BhY2thZ2U7CiAgIHJldHVybiBlbXB0eV9w YWNrYWdlOwogfQogCiBjb25zdCBzdGQ6OnN0cmluZwogU29sdmFibGVWZXJz aW9uOjpTRGVzYyAoKSBjb25zdAogeworICBpZiAoIWlkKQorICAgIHJldHVy biAiIjsKICAgU29sdmFibGUgKnNvbHZhYmxlID0gcG9vbF9pZDJzb2x2YWJs ZShwb29sLCBpZCk7CiAgIGNvbnN0IGNoYXIgKnNkZXNjID0gcmVwb19sb29r dXBfc3RyKHNvbHZhYmxlLT5yZXBvLCBpZCwgU09MVkFCTEVfU1VNTUFSWSk7 CiAgIHJldHVybiBzZGVzYzsKQEAgLTE5Nyw2ICsyMDcsOCBAQCBTb2x2YWJs ZVZlcnNpb246OnNvdXJjZVBhY2thZ2UgKCkgY29uc3QKIHZvaWQKIFNvbHZh YmxlVmVyc2lvbjo6Zml4dXBfc3BrZ19pZCAoU29sdmFibGVWZXJzaW9uIHNw a2dfaWQpIGNvbnN0CiB7CisgIGlmICghaWQpCisgICAgcmV0dXJuOwogICBT b2x2YWJsZSAqc29sdmFibGUgPSBwb29sX2lkMnNvbHZhYmxlKHBvb2wsIGlk KTsKICAgUmVwb2RhdGEgKmRhdGEgPSByZXBvX2xhc3RfcmVwb2RhdGEoc29s dmFibGUtPnJlcG8pOwogICBJZCBoYW5kbGUgPSBpZDsKQEAgLTIzNyw2ICsy NDksOCBAQCBTb2x2YWJsZVZlcnNpb246OmFjY2Vzc2libGUgKCkgY29uc3QK IHBhY2thZ2Vfc3RhYmlsaXR5X3QKIFNvbHZhYmxlVmVyc2lvbjo6U3RhYmls aXR5ICgpIGNvbnN0CiB7CisgIGlmICghaWQpCisgICAgcmV0dXJuIFRSVVNU X1VOS05PV047CiAgIFNvbHZhYmxlICpzb2x2YWJsZSA9IHBvb2xfaWQyc29s dmFibGUocG9vbCwgaWQpOwogICBJZCBzdGFiaWxpdHlfYXR0ciA9IHBvb2xf c3RyMmlkKHBvb2wsICJzb2x2YWJsZTpzdGFiaWxpdHkiLCAxKTsKICAgcmV0 dXJuIChwYWNrYWdlX3N0YWJpbGl0eV90KXJlcG9fbG9va3VwX251bShzb2x2 YWJsZS0+cmVwbywgaWQsIHN0YWJpbGl0eV9hdHRyLCBUUlVTVF9VTktOT1dO KTsKLS0gCjIuMTQuMgoK --------------3E96C5175C6A98660DF5A1CF--