Re: [PATCH setup] Keyboard accelerators for install/reinstall/uninstall

[Jon Turney <jon.turney@dronecode.org.uk>]

On 22/08/2022 16:29, Christian Franke wrote:
> Jon Turney wrote:
>> On 14/08/2022 12:57, Christian Franke wrote:
>>> This eases state changes of a selected sequence of packages.
>>
>> Nice!  The keyboard control of the package chooser was a bit of an 
>> after-thought, which it really shouldn't be.
> 
> Thanks - revised patch is attached.
> 

Thanks.  This looks good.  Please apply.

>>> Ctrl+U is in particular useful to cleanup installations in 
>>> conjunction with "unneeded" view:
>>> https://sourceware.org/pipermail/cygwin-apps/2022-August/042185.html
>>>
>>> Open issue: Add some visual clue (tooltip?) to make this 
>>> functionality more obvious.
>>
>> Yeah.  These shortcuts should also be accelerators for the package 
>> action selection popup menu, which would make them more discoverable?
> 
> Handling these in the popup menu is possibly tricky. According to 
> documentation of TrackPopupMenu(), hWndListView "receives all messages 
> from the menu" which is apparently not the case.

Confused. I don't think that matters (we could probably be using 
TPM_NONOTIFY), because we use TPM_RETURNCMD.

If we mark accelerators in the menu:

--- a/res/en/res.rc
+++ b/res/en/res.rc
@@ -573,11 +573,11 @@ BEGIN
      IDS_PROGRESS_POSTINSTALL "Running..."
      IDS_PROGRESS_SOLVING "Solving dependencies..."
      IDS_ACTION_DEFAULT "Default"
-    IDS_ACTION_INSTALL "Install"
-    IDS_ACTION_UNINSTALL "Uninstall"
+    IDS_ACTION_INSTALL "&Install"
+    IDS_ACTION_UNINSTALL "&Uninstall"
      IDS_ACTION_SKIP "Skip"
      IDS_ACTION_KEEP "Keep"
-    IDS_ACTION_REINSTALL "Reinstall"
+    IDS_ACTION_REINSTALL "&Reinstall"
      IDS_ACTION_RETRIEVE "Retrieve"
      IDS_ACTION_UNKNOWN "Unknown"
      IDS_ACTION_SOURCE "Source"

They appear when the menu is opened by pressing the menu key (or always, 
if "Underline access keys when available" is on in ease-of-access 
settings), and menu items can be chosen using them.

It's not quite that straightforward because we need to remove the '&' 
when those strings are used elsewhere (e.g. in the action column), but I 
think it can be done...

>>> @@ -670,6 +670,10 @@ packagemeta::set_action (_actions action, 
>>> packageversion const &default_version,
>>>     else if (action == Uninstall_action)
>>>       {
>>>         desired = packageversion ();
>>> +      pick (false);
>>> +      srcpick (false);
>>> +      if (!installed)
>>> +    action = NoChange_action;
>>
>> Hmm... why is adding this needed?
> 
> Otherwise a strange state change would occur at least in the GUI when an 
> install request is undone:
> 
> "Skip" == Ctrl+I ==> "3.2-1" == Ctrl+U ==> "Uninstall"
> 
> The new patch includes another addition which prevents this on installs 
> from local directory when the current default version is not yet 
> downloaded:
> 
> "Skip" == Ctrl+I ==> "" (empty)

I see.  But these work correctly when chosen via the action menu 
dropdown?  I forget how this all works, and there probably are separate 
paths which duplicate stuff, but this suggests to me that this is 
increasing that duplication, which isn't the desired direction of travel...

> BTW, I didn't understand this line:
> 
>    void
>    packagemeta::set_action (...)
>    {
>      ...
>      else if (action == Install_action)
>        {
>          desired = default_version;
>          if (desired)
>            {
>              if (desired != installed)
>                if (desired.accessible ())
>                  {
>                    ...
>                    pick (true);
>                    srcpick (false);
>                  }
>                else
>                  {
>                    pick (false);
>                    srcpick (true); <== why true? ==
>                  }
>                ...
> 

Yeah, I don't understand why that's there either.  It seems like it's 
going to give you the source package if you've asked for the package to 
be installed, but it's not available.

I think It's some ancient cruft which nobody would notice if we removed :)