From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4474 invoked by alias); 17 Oct 2017 18:47:04 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 4464 invoked by uid 89); 17 Oct 2017 18:47:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=our, Hx-spam-relays-external:ESMTPA, HContent-Transfer-Encoding:8bit X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 18:47:02 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3801820DCB for ; Tue, 17 Oct 2017 14:47:01 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Tue, 17 Oct 2017 14:47:01 -0400 X-ME-Sender: Received: from [192.168.1.102] (host86-179-113-201.range86-179.btcentralplus.com [86.179.113.201]) by mail.messagingengine.com (Postfix) with ESMTPA id C16D17F91F for ; Tue, 17 Oct 2017 14:47:00 -0400 (EDT) Subject: Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP) To: cygwin-apps@cygwin.com References: <20170531105015.162228-1-jon.turney@dronecode.org.uk> <488ba627-de58-ddc7-7f69-696adae76b8a@cornell.edu> <9bcf50cf-81bc-c9d1-3ac3-b7e1a3522045@dronecode.org.uk> <5441628f-a99a-1611-616a-da98ea9a0e12@cornell.edu> <7044db65-8b6e-6bf6-a079-99397917ce43@cornell.edu> <8e655423-ef53-3aeb-3d6c-de5021d3bd87@dronecode.org.uk> <5e74cacd-3153-1561-3cd2-5ece0e35a2d2@cornell.edu> <003a8566-ad2b-a962-725a-4384fd5e4c64@cornell.edu> From: Jon Turney Message-ID: Date: Tue, 17 Oct 2017 18:47:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <003a8566-ad2b-a962-725a-4384fd5e4c64@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-10/txt/msg00067.txt.bz2 On 17/10/2017 13:44, Ken Brown wrote: > On 10/10/2017 7:18 AM, Ken Brown wrote: >> On 9/29/2017 4:33 PM, Ken Brown wrote: >>> I'll resume my testing after I return. >> >> I've just started testing (based on the current HEAD of >> topic/libsolv), and so far everything looks good. > > I came across a situation where a SolvableVersion method was being > called on a trivial object (with pool and id both 0).  This caused a > crash when pool_id2solvable(pool, id) was called and pool was > dereferenced.  There's probably a bug that led to this situation.  [It > involved a local install in which a package was listed in two different > setup.ini files, but the tarballs existed only in one.]  I plan to > investigate this further.  But in any case, we shouldn't crash.  Patch > attached. I thought about putting this in, but decided against it as it would probably catch some mistakes I had made... But yeah, for production use, I think not crashing is probably a good idea :). Although I guess we might want asserts or something, if we think these cases shouldn't be happening.