public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH cygport 2/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH
Date: Sat, 06 May 2017 11:32:00 -0000	[thread overview]
Message-ID: <cd1d9eb0-4d6a-746d-8bf4-e9c5825e16f7@dronecode.org.uk> (raw)
In-Reply-To: <44e30d65-194d-5185-f230-e2f3859a6894@cygwin.com>

On 05/05/2017 23:06, Yaakov Selkowitz wrote:
> On 2017-05-02 08:13, Jon Turney wrote:
>> The values which SRC_URI and PATCH_URI evaluate to should not change
>> depending on ARCH, as this will make the source package arch-dependent
>
> I think this would require a proper src_prep first, so that patches may
> be still be arch-conditionalized there instead.

Ok, that makes sense.

So I guess there could be a hook called for each patch to cause it to be 
applied/skipped, or to adjust the patch list?  Or do you think more of 
__src_prep needs to be customizable?

  reply	other threads:[~2017-05-06 11:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02 13:14 [PATCH cygport 0/3] cygport patches Jon Turney
2017-05-02 13:14 ` [PATCH cygport 1/3] Pass DEPEND through to .hint for source package as build-depends: Jon Turney
2017-05-05 20:42   ` Yaakov Selkowitz
2017-05-05 23:54     ` Brian Inglis
2017-05-06  5:39     ` Achim Gratz
2017-05-06 11:03     ` Jon Turney
2017-05-06 16:10       ` Brian Inglis
2017-05-02 13:14 ` [PATCH cygport 2/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH Jon Turney
2017-05-02 13:31   ` Andrew Schulman
2017-05-02 13:39     ` Jon Turney
2017-05-02 14:30       ` Andrew Schulman
2017-05-05 22:05   ` Yaakov Selkowitz
2017-05-06 11:32     ` Jon Turney [this message]
2017-05-11 12:07       ` Jon Turney
2017-05-02 13:14 ` [PATCH cygport 3/3] Update documentation of all and almostall Jon Turney
2017-05-02 14:29   ` Andrew Schulman
2017-05-02 15:12     ` Jon Turney
2017-05-05 20:45       ` Yaakov Selkowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd1d9eb0-4d6a-746d-8bf4-e9c5825e16f7@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).