public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: Re: [ITP] mailutils 3.2
Date: Wed, 19 Apr 2017 20:11:00 -0000	[thread overview]
Message-ID: <cdb64703-bbc3-761c-e107-2ac01fe05cf7@cornell.edu> (raw)
In-Reply-To: <461c27f8-a0ed-27c2-f26a-12dd3fb55a8c@dronecode.org.uk>

On 4/19/2017 1:17 PM, Jon Turney wrote:
> mailutils.cygport:
>
> 3.2-missing_tests.patch is listed in SRC_URI.  I'm guess this is an
> error, or it needs to be a URL?

No, this was deliberate.  There's some kind of glitch in the build 
system that causes the missing tests to be removed again, so I have to 
reapply the patch as part of src_test().  Adding it to SRC_URI seemed 
like the easiest way to make sure it was available.

> src_tests() ignores the result of make check.

Thanks.  I have no idea why I did that, but I've fixed it now.

> I added 'mailutils' to your authorized uploads, so you can go ahead or
> wait until Yaakov has some time to tell you what else is wrong with your
> package :)

I'll wait a few more days to see if Yaakov has further comments.

Thanks for the review.

Ken

  reply	other threads:[~2017-04-19 20:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-02 22:39 Ken Brown
2017-04-19 17:17 ` Jon Turney
2017-04-19 20:11   ` Ken Brown [this message]
2017-04-20 18:55     ` Yaakov Selkowitz
2017-04-20 20:11       ` Ken Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdb64703-bbc3-761c-e107-2ac01fe05cf7@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).