From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10hn2222.outbound.protection.outlook.com [52.100.156.222]) by sourceware.org (Postfix) with ESMTPS id 3F36A3896C0E for ; Mon, 30 Nov 2020 19:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3F36A3896C0E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fpwsy9RJvi5q9K2bkZQoZJeAMZe8AYVpItVD99KNHGKh2a0y5iR19xCOz+e+tF75e6sqGGeU/35MzvmzJWpLe1oOeAFxqWJh33EcXrQpK5kPejA7XWprFgfwDkctDeZN6d6dPk128rMcS0X6gUqguCnv60gdTFuzA4nJVW/qJ2xOtu7/iGSJtRmLa+WtDBLt0TPj8JhJjp7f6BAcub2iaOpzb7gkFrTgsQxkzpkG3E7igqFfIoRjmG7ecKgRNLyn72h2I4bpQSrZqKSE/HuFQIq5zFINnwl5IMrP22MY18ucfY/IspVxwcoQdyo46XG/ax7Z+/uQ0963xwW94QMByw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0PzPNzmEb22HxlBFGNpyf8fuymPZ5isk0auygvLOBO4=; b=f34GIO2kYQijHbwG+iYV3IVheN7cE/04woVmfB/COOU0T4XOnjndNCqVxmEejjEyDFfEFXsOYyTqnmXtKlW0GuBpEbOL+AHO8xNgyV//XFgA848TZnQuCbyRbQizQFxegrDfJYUwDm2hfWF/dcHqJxOnYiPIh0FxDWw4cmtH7F8w3TSlr+gWyTKrVCHgyxQF1v3FzvE6eAyG9SHPd32kaQ+hGLE7MYUciACJ/4qX5L4z2e+IgNk7FwpmxsL+xIk90rFroONUPvsBmYWpPci0+P/DINDL7JJ3wHyJlqLzS6jA65t5JRoZtyMHHsgcT6nFC5OWMb8s4wKgGV2LnLrjLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none Received: from MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) by MN2PR04MB5599.namprd04.prod.outlook.com (2603:10b6:208:fe::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25; Mon, 30 Nov 2020 19:47:03 +0000 Received: from MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::113e:c874:1207:eca8]) by MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::113e:c874:1207:eca8%6]) with mapi id 15.20.3611.025; Mon, 30 Nov 2020 19:47:02 +0000 Subject: Re: [ITP] gengetopt 2.23 To: cygwin-apps@cygwin.com References: <8842c6fe-3a5d-5d5f-5691-2d756ee89174@upc.edu> From: Ken Brown Message-ID: Date: Mon, 30 Nov 2020 14:46:53 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 In-Reply-To: <8842c6fe-3a5d-5d5f-5691-2d756ee89174@upc.edu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [68.175.129.7] X-ClientProxiedBy: CH0PR04CA0101.namprd04.prod.outlook.com (2603:10b6:610:75::16) To MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.17] (68.175.129.7) by CH0PR04CA0101.namprd04.prod.outlook.com (2603:10b6:610:75::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25 via Frontend Transport; Mon, 30 Nov 2020 19:47:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 36fce07f-51ce-4e35-126d-08d89568b57b X-MS-TrafficTypeDiagnostic: MN2PR04MB5599: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?Windows-1252?Q?qyMzOX/zgidBotdEbzylU4/YbLYqdwk0C69vy8Vqp8XtoYqhjO6HA2xE?= =?Windows-1252?Q?OKp/rOI3Z3AMhBLL4Mxa6fLJXvpwO5ClCQweV/pRy5+j4si+wEXTTQce?= =?Windows-1252?Q?6RMdnQPHXT5i9UxHHqhmuys+3lev3XkWC8PuAyRNdXLoWJqCSIUKqjuo?= =?Windows-1252?Q?/WFNoT0rjnfNeqRwOsjK4PhVfFa6FsSJKWdTTDJed8OoAvc2c3+3Pe57?= =?Windows-1252?Q?YTu5ExcMx91RKg7fPlAx/77A56HaeOGVjPdDGwNZpJEfYy0HcNv0wrkl?= =?Windows-1252?Q?73LKPKrh91DvzDIM+lPXUX7maSk0LcbE0PTuO/VCbOGHASjAb6zHX3to?= =?Windows-1252?Q?/Y14H/YldaU45bF4v9eXIsOChVuzTBBrCcLygs1X1UK1wlFxZ/YCQLJ7?= =?Windows-1252?Q?fREOQQkblMC9WU3t8nuTLgIhUC6YdvIfYdhpE93TwVeEfvnen0Q9n6Jw?= =?Windows-1252?Q?VBolJV6qNGG3Z0bH9wBAyGOqYlkRjP5LQrJV8JmEPDkJppOGtGpMSv29?= =?Windows-1252?Q?kwyR6g0mok0lYo32JVdQDbUy7Ft7d9wrMx+xg3/36FMMzr0eEtnd2D2K?= =?Windows-1252?Q?idTgLfSJj9zD/bLlRRgIonPaNQxmpo4B8O2zftU2uy03iU/bbmS+MT/Q?= =?Windows-1252?Q?lhHkQSyzZOrDjIg6M7ihjjqJBoq8TkZDCtWvbJfT1frmdaGZ1QDGZVMI?= =?Windows-1252?Q?ORuDwc4xtFICfXvMt6SSVJap2z/jZbu7+g5x2yMsmDfC4p22hnZWnb6n?= =?Windows-1252?Q?F5ZtcX1LQBUmFfEGb02xXrJj0qcNKVgUh9hSQX7cPbneeZQTqlNKgwdK?= =?Windows-1252?Q?JHjCIA9jgdI1ke0evC/Dr/DWzr1qEXQhVOuzWW7EeSOyDpkLfw2SKDLS?= =?Windows-1252?Q?m7sjhfxOvACsrGgRidZXH8dL7oArVv4BU7MvnfpXHS4dMYHPkXJpthUy?= =?Windows-1252?Q?yRWCRw72Jl+rVAN4fn8RUWqETXMlSsfTxtWuUavhQ+Lme9jD1FA4UREb?= =?Windows-1252?Q?M/01wD42yNLw+A6WsaRhaX/768PIcNfZ7bCShK/i93cuKwvyrkVAB/+b?= =?Windows-1252?Q?AojEj5WlriDnpz63N54bPH+5ac7wZdn1CHsdtUBOoRO8S8TCgn7pzXzP?= =?Windows-1252?Q?Z7Um6x2+PVBTrjEPViZ8N2GAkYW32SR8OEir0DQ5OAOEZg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:9; SRV:; IPV:NLI; SFV:SPM; H:MN2PR04MB6176.namprd04.prod.outlook.com; PTR:; CAT:OSPM; SFS:(4636009)(136003)(366004)(396003)(346002)(39860400002)(376002)(966005)(6486002)(316002)(8676002)(52116002)(786003)(956004)(2616005)(16576012)(16526019)(31696002)(2906002)(8936002)(26005)(75432002)(186003)(478600001)(31686004)(53546011)(86362001)(6916009)(66946007)(66476007)(66556008)(36756003)(83380400001)(6666004)(5660300002)(2004002)(43740500002); DIR:OUT; SFP:1501; X-MS-Exchange-AntiSpam-MessageData: =?Windows-1252?Q?ETegq1fDSEAWUBSX5LPQvVnCrfwuLFASWpr2A6EcXErtekKe8M5FiRJM?= =?Windows-1252?Q?yqj9Hb32ITmhwzH7McKLDhq+jYRju/raNE9c9lo3V1tuGNMIY+8e3V40?= =?Windows-1252?Q?2YQKVdkhdu2krwgOQBEmzjqHnRVF2mYtzFR5NFJ5or/dateCx+q9DnUr?= =?Windows-1252?Q?gr++kkdtgqPPNmAE29/HzabuSG5MQdftUvPT+weRrejVygxwFY05XscI?= =?Windows-1252?Q?KcOPsCYL3tf4/I5X6EbggrDpIQGh8DTBsY+K5U2Ta9xlgbsj28DaVB3I?= =?Windows-1252?Q?T2YCnME/Ks5YJBoUBEMtGHKXUHU1LBwZFweefq7r82JQjNJZNnaI0aOR?= =?Windows-1252?Q?QsXODJK9wuYqwt2BABPnki4i9rMAs6nyJMPZ2/oG856KeXjIhNISUNKh?= =?Windows-1252?Q?QIVPULopYftXqIgJmsDzzIMlDXBk9wTPX3QUGN3dW/lA0luP6tgXyTgc?= =?Windows-1252?Q?ebD77ycMP01W/F6kq2SavQJoLgeUtNC3033rLlxmeZlZJeDQhdUZMrWE?= =?Windows-1252?Q?FkfN8Qr1KWKBJfjEFP7K5BhWDtRQLNEEV6rfed1XA5u5xiGDLqSiGK2A?= =?Windows-1252?Q?RE+tBljcrtfSBCu7zSymTjT7uhJCaFBY7PCH2s4cnEYroNMr18aUKO+a?= =?Windows-1252?Q?zOW5Km2DuhvO1kRQu0XLvODO2fTMKRvu6OEpInOJYFB/SMP3zZvbv4pe?= =?Windows-1252?Q?NCBKJMBr2dHNjdNSLREi05lpq9TRhCBVM9Zp4GYV8XEWbuACTe8R2yxX?= =?Windows-1252?Q?FVQ0GkMy0rR8VqRGjcMjVYQ/IlPN5xyPJY9gPpeilYffVCslKhkEnRw6?= =?Windows-1252?Q?o5laJPD45QeDaCOSGDBPN1yTJKxXTn5f43gczROfwfF/b2mPDJl0yrNj?= =?Windows-1252?Q?+LzWalVUVKPc+gyQGR/mtA0DL0OaKuS9Rey6g/F9hQk5M7bukSY8Nzfk?= =?Windows-1252?Q?pDlSlDoBFQn6zjD2/JBvhS6peenydpkCQwtO4lWV635aSQPXAGu3+Mm3?= =?Windows-1252?Q?Ppr1xwmgQZ+4FroGZmLDo07Wek7R9Yo7Sh/WD2LqgBno/+Jwv3w=3D?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 36fce07f-51ce-4e35-126d-08d89568b57b X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6176.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2020 19:47:02.8093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MxsN5cyx7a0HvQRxp7nceSDeU94eqtVypNxUAhfWmaRZZUvPQkMw/99WL5hWFR93xpd9WQYWAr1ok3gk12ZQIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5599 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, KAM_SHORT, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 19:47:05 -0000 On 11/29/2020 2:19 PM, Rafel Amer Ramon wrote: > > Hi, > > [ITP] gengetopt 2.23 > > Program home page: https://www.gnu.org/software/gengetopt > > License: This program is free software; you can redistribute it and/or modify > it under the terms of the GNU General Public License as published by > the Free Software Foundation; either version 3 of the License, or > (at your option) any later version. > > Debian package: https://packages.debian.org/buster/gengetopt > > I have uploaded the files to https://github.com/rafelamer/cygwin-gengetopt > > https://github.com/rafelamer/cygwin-gengetopt/raw/main/gengetopt.cygport > https://github.com/rafelamer/cygwin-gengetopt/raw/main/gengetopt-2.23.tar.xz > > > https://github.com/rafelamer/cygwin-gengetopt/raw/main/gengetopt-2.23-1.x86_64/dist/gengetopt/gengetopt-2.23-1-src.hint > > https://github.com/rafelamer/cygwin-gengetopt/raw/main/gengetopt-2.23-1.x86_64/dist/gengetopt/gengetopt-2.23-1-src.tar.xz > > https://github.com/rafelamer/cygwin-gengetopt/raw/main/gengetopt-2.23-1.x86_64/dist/gengetopt/gengetopt-2.23-1.hint > > https://github.com/rafelamer/cygwin-gengetopt/raw/main/gengetopt-2.23-1.x86_64/dist/gengetopt/gengetopt-2.23-1.tar.xz This looks good. I just have a few minor comments. - The SUMMARY should generally not start by repeating the package name. "A tool to write command line option parsing code for C programs" suffices. - I suggest adding HOMEPAGE="https://www.gnu.org/software/gengetopt/" - The build produces a source patch because of changes to test files: >>> Creating source patches tests/test_conf_parser_ov2.c | 2 +- tests/test_conf_parser_ov3.c | 4 ++-- tests/test_conf_parser_ov4.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) You can use DIFF_EXCLUDES to avoid this. - There are two failing tests that you might want to look into at some point. - I noticed that your github repo contains all the build files. Once you become maintainer, you will be able to push to the official source repo for the package (see https://cygwin.com/packaging/repos.html). This should not contain only the files needed for building the package (i.e., only the cygport file in your case). Pushing to that repo triggers an automatic build (see https://cygwin.com/cgi-bin2/jobs.cgi). I'll go ahead and add you to https://cygwin.com/cygwin-pkg-maint, but I'm not sure how to parse your name. Should it be "Rafel Amer" or "Rafel Amer Ramon" or something else? Thanks for becoming a maintainer. Ken