From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55950 invoked by alias); 29 Aug 2016 10:03:36 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 55939 invoked by uid 89); 29 Aug 2016 10:03:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=collapse, composed, unpacking, View X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Aug 2016 10:03:25 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6B3F120501 for ; Mon, 29 Aug 2016 06:03:23 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Mon, 29 Aug 2016 06:03:23 -0400 Received: from [192.168.1.102] (host31-51-206-108.range31-51.btcentralplus.com [31.51.206.108]) by mail.messagingengine.com (Postfix) with ESMTPA id F0A31F29D4 for ; Mon, 29 Aug 2016 06:03:22 -0400 (EDT) Subject: Re: [PATCH setup 0/4] Use a pop-up menu to select chooser view filter To: cygwin-apps@cygwin.com References: <20160824141537.34836-1-jon.turney@dronecode.org.uk> <20160824165037.GA9783@calimero.vinschen.de> <62665e05-fe7c-1aa0-29bd-9342d90ab29a@dronecode.org.uk> <20160826080704.GB23935@calimero.vinschen.de> <20160826152526.GU9783@calimero.vinschen.de> From: Jon Turney Message-ID: Date: Mon, 29 Aug 2016 10:03:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160826152526.GU9783@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2016-08/txt/msg00099.txt.bz2 On 26/08/2016 16:25, Corinna Vinschen wrote: > On Aug 26 15:41, Jon Turney wrote: >> On 26/08/2016 09:07, Corinna Vinschen wrote: >>> On Aug 25 15:34, Yaakov Selkowitz wrote: >>>> On 2016-08-25 14:11, Jon Turney wrote: >>>>> On 24/08/2016 17:50, Corinna Vinschen wrote: >>>>>> One question: Usually the popup menu itself reflects the current choice. >>>>>> So, wouldn't it make more sense to have the text "View" just as plain >>>>>> text to the left, and the actual popup menu next right to it, showing >>>>>> the current choice? Yes? No? Shut up? >>>>> >>>>> Yeah, there is probably better visual language to be used here. >>>>> >>>>> If the popup menu itself reflects the current choice, perhaps we don't >>>>> need a caption with the current choice at all (i.e. just a button that >>>>> says "View" and that's all...) >>>>> >>>>> I'd really like that button to have a '▾' to indicate it has a >>>>> drop-down, but that seems hard to achieve. >>>>> >>>>> (This might be done with the BS_SPLITBUTTON style (which combines a >>>>> button and dropdown menu), but that is sadly only supported by common >>>>> controls on Vista or later.) >> >> Two more patches follow this mail, which do that. >> >> I'm still not totally happy with this. It could give the impression that >> something is supposed to happen when the "View" part of the the button is >> clicked, and there is no keyboard shortcut to open the view selection menu. > > Looks like I didn't explain well enough what I meant. What I had in > mind was a pull-down menu just as you did, but which reflects the > current state in its text. The word "View" would just show up in fixed > text field left of it. I. e.: > > +--------------------+ > View: | Category | v | > +--------------------+ > > After the user chooses "Pending": > > +--------------------+ > View: | Pending | v | > +--------------------+ > > I think this is what most users expect from this pull-down menu style, > isn't it? Ah, right. Using a drop-down list is the correct thing to do here. I had the idea in the back of my mind that in future it might be worthwhile to add other actions here (e.g. expand/collapse all in category view, unpacking the fixed filter set we support into the tests they are composed of, etc.), where a menu would be more appropriate, but I guess we can cross that bridge if we get to it... See the replacement [4/4] to follow this mail.