From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps <cygwin-apps@cygwin.com>
Subject: setup and colons in filenames
Date: Wed, 25 Oct 2017 15:50:00 -0000 [thread overview]
Message-ID: <d5f2eaf3-b24f-0430-71fd-50bce87e0b32@cornell.edu> (raw)
This is a followup to the thread started here:
https://cygwin.com/ml/cygwin-patches/2017-q4/msg00012.html
Currently setup's parse_filename is not correctly parsing filenames in
/etc/setup/installed.db that contain colons, as explained in the above
thread. It would be easy to fix this by just ripping out the 'base'
function, except for the fact that parse_filename is called by
ScanFindVisitor::visitFile.
I don't know enough about WIN32_FIND_DATA to know whether the call to
'base' is needed for that use of parse_filename. If so, is it safe to
skip all colons in that setting, since we're dealing with Win32
filenames and they don't see the colons in Cygwin filenames?
Do we need two versions of parse_filename, one that calls base and one
that doesn't?
Ken
next reply other threads:[~2017-10-25 15:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 15:50 Ken Brown [this message]
2017-10-25 19:23 ` Jon Turney
2017-10-25 20:16 ` Corinna Vinschen
2017-10-25 20:36 ` Jon Turney
2017-10-25 21:00 ` Corinna Vinschen
2017-10-26 16:14 ` Jon Turney
2017-10-26 16:14 ` Jon Turney
2017-10-26 17:04 ` Ken Brown
2017-10-26 17:20 ` Jon Turney
2017-10-26 17:42 ` Achim Gratz
2017-10-26 17:49 ` Jon Turney
2017-10-26 18:25 ` Achim Gratz
2017-10-27 8:47 ` Corinna Vinschen
2017-10-27 10:40 ` Achim Gratz
2017-10-27 13:44 ` Jon Turney
2017-10-27 15:20 ` Ken Brown
2017-10-27 16:28 ` Corinna Vinschen
2017-10-27 13:43 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5f2eaf3-b24f-0430-71fd-50bce87e0b32@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).