From: Jon Turney <jon.turney@dronecode.org.uk>
To: Adam Dinwoodie <adam@dinwoodie.org>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: Version string of package
Date: Wed, 18 Jan 2023 16:17:31 +0000 [thread overview]
Message-ID: <d7be062c-cab5-38c7-76ed-69bea4ebba06@dronecode.org.uk> (raw)
In-Reply-To: <20230117235902.f7sr234ptcj77ees@lucy.dinwoodie.org>
On 17/01/2023 23:59, Adam Dinwoodie wrote:
> On Fri, Jan 13, 2023 at 01:22:44PM +0000, Jon Turney via Cygwin-apps wrote:
>>
>> [1] https://cygwin.com/packaging-package-files.html
>
> I just spotted [0] in the Cygport documentation, and was reminded of
> this conversation. According to that, the version string is explicitly
> allowed to include hyphens! I suspect that's fundamentally a
> documentanion bug these days, and should just be expunged...
>
> [0]: https://cygwin.github.io/cygport/syntax_cygpart.html#VERSION
>
> Quick patch below; I can submit this properly as a GitHub PR or with
> `git send-email` or otherwise if that'd be useful...
>
> diff --git a/lib/syntax.cygpart b/lib/syntax.cygpart
> index 4a400a71..6b992031 100644
> --- a/lib/syntax.cygpart
> +++ b/lib/syntax.cygpart
> @@ -316,7 +316,7 @@ __target_is_embedded() {
> #****v* Globals/VERSION
> # DESCRIPTION
> # The upstream package version number. PV must begin with a digit 0-9, and
> -# subsequent characters can be a digit, letter, dot, hyphen, or underscore.
> +# subsequent characters can be a digit, letter, dot, or underscore.
> #****
> #****v* Globals/RELEASE
> # DESCRIPTION
Thanks. But that's not quite right either, since we currently allow '+'
in version.
I revised [1] a bit to mention what I think the valid character set is,
and disallow a hyphen in version. It might make sense to point to that
from NAME, VERSION, RELEASE in the cygport documentation, rather than
repeat it.
(That's assuming I've got the intersection of what's valid in cygport,
calm and setup correct, of course)
prev parent reply other threads:[~2023-01-18 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 11:52 Takashi Yano
2023-01-13 13:22 ` Jon Turney
2023-01-13 14:21 ` Takashi Yano
2023-01-13 19:11 ` Brian Inglis
2023-01-17 23:59 ` Adam Dinwoodie
2023-01-18 16:17 ` Jon Turney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7be062c-cab5-38c7-76ed-69bea4ebba06@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=adam@dinwoodie.org \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).