From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60645 invoked by alias); 25 Oct 2017 19:43:23 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 60635 invoked by uid 89); 25 Oct 2017 19:43:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=retire, Hx-spam-relays-external:ESMTPA, xxx X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Oct 2017 19:43:21 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5F18422401 for ; Wed, 25 Oct 2017 15:43:20 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Wed, 25 Oct 2017 15:43:20 -0400 X-ME-Sender: Received: from [192.168.1.102] (host86-179-113-201.range86-179.btcentralplus.com [86.179.113.201]) by mail.messagingengine.com (Postfix) with ESMTPA id 0A6F27F955 for ; Wed, 25 Oct 2017 15:43:19 -0400 (EDT) Subject: Re: [BUG] mksetupini To: cygwin-apps@cygwin.com References: <87mv4fku1r.fsf@Rainer.invalid> From: Jon Turney Message-ID: Date: Wed, 25 Oct 2017 19:43:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87mv4fku1r.fsf@Rainer.invalid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00123.txt.bz2 On 25/10/2017 18:37, Achim Gratz wrote: > Consider the following situation: an old package with setup.hint that > has dependency to "abc" and a new package version using versioned hint > files without said dependency. Not the old package files get deleted, > but setup.hint stays in the directory. Running mksetupini correctly > determines that the setup.hint file needs to be removed, but still > generates a setup.ini that makes the package depend on "abc". > > The expected behaviour of course would be that it doesn't use the > information in that file (which no longer exists at the end of the run > anyway). Yeah, this edge case isn't handled correctly: There's a note in the source code [1] that basically says "XXX: do complex stuff here". I believe If you run mksetupini again, you'll get the correct result, as the unneeded setup.hint has been removed. Since I want to retire setup.hin support fairly soon, I'm not really planning on fixing this... [1] https://cygwin.com/git/gitweb.cgi?p=cygwin-apps/calm.git;a=blob;f=calm/package.py;h=ed4cf009ce98c00f9182818353cc454f0c9525b9;hb=HEAD#l875