From: Jon Turney <jon.turney@dronecode.org.uk>
To: Ken Brown <kbrown@cornell.edu>, cygwin-apps@cygwin.com
Subject: Re: [PATCH setup] Make sure that fatal error messages are visible
Date: Fri, 05 Jan 2018 13:54:00 -0000 [thread overview]
Message-ID: <d9ee0053-fb2a-c0f4-9ede-8e7336de9578@dronecode.org.uk> (raw)
In-Reply-To: <8715e942-43c4-d222-7428-bad40e9337c1@cornell.edu>
On 28/12/2017 01:38, Ken Brown wrote:
> On 12/21/2017 5:55 PM, Ken Brown wrote:
>> On 12/20/2017 12:09 PM, Ken Brown wrote:
>>> On 12/20/2017 11:19 AM, Jon Turney wrote:
>>>> On 19/12/2017 00:53, Ken Brown wrote:
>>>>> The message box produced by TOPLEVEL_CATCH could be hidden by whatever
>>>>> window was previously being displayed, so that setup appeared to hang.
>>>>> Fix this by giving fatal error message boxes type MB_SETFOREGROUND.
>>>>
>>>> This is good as far as it goes, but is kind of working around the
>>>> fact that fatal() is being called with an NULL owner HWND.
>
> I think I have a better solution, which simply avoids calling fatal()
> with a NULL owner HWND (with one exception).
>
> New patch attached.
Great. Please apply.
prev parent reply other threads:[~2018-01-05 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 0:53 Ken Brown
2017-12-20 16:19 ` Jon Turney
2017-12-20 17:09 ` Ken Brown
2017-12-21 3:02 ` Brian Inglis
2017-12-21 13:20 ` Ken Brown
2017-12-21 22:55 ` Ken Brown
2017-12-28 1:38 ` Ken Brown
2018-01-05 13:54 ` Jon Turney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9ee0053-fb2a-c0f4-9ede-8e7336de9578@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).