From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24572 invoked by alias); 30 Oct 2017 15:55:59 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 24561 invoked by uid 89); 30 Oct 2017 15:55:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:ESMTPA X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Oct 2017 15:55:58 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9D56720AEA for ; Mon, 30 Oct 2017 11:55:56 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Mon, 30 Oct 2017 11:55:56 -0400 X-ME-Sender: Received: from [192.168.1.102] (host86-179-113-201.range86-179.btcentralplus.com [86.179.113.201]) by mail.messagingengine.com (Postfix) with ESMTPA id 448C77E17C for ; Mon, 30 Oct 2017 11:55:56 -0400 (EDT) Subject: Re: [[PATCH setup] 0/3] Prepare for colons in version numbers To: cygwin-apps@cygwin.com References: <20171027184723.9324-1-kbrown@cornell.edu> From: Jon Turney Message-ID: Date: Mon, 30 Oct 2017 15:55:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171027184723.9324-1-kbrown@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00166.txt.bz2 On 27/10/2017 19:47, Ken Brown wrote: > A future version of setup might allow version numbers of the form > e:v-r, where is an epoch. Currently setup doesn't parse these > correctly when reading installed.db. In case ScanFindVisitor is used, > there is an additional problem in reading filenames containing colons. > The reading is done by Win32 functions, and the illegal characters > like ':' aren't translated. > > Ken Brown (3): > Remove the function filemanip.cc:base > Bump the installed.db version to 4 > Remove the ScanFindVisitor class Great, thanks. I'll hold 2/3 back a bit, as bumping the installed.db version makes it a pain to go back to the released setup version after testing...