From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-a1p-077723.sys.comcast.net (resqmta-a1p-077723.sys.comcast.net [IPv6:2001:558:fd01:2bb4::9]) by sourceware.org (Postfix) with ESMTPS id DCAFF3851148 for ; Wed, 26 Oct 2022 00:44:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DCAFF3851148 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=acm.org Received: from resomta-a1p-077060.sys.comcast.net ([96.103.145.238]) by resqmta-a1p-077723.sys.comcast.net with ESMTP id nUFLoqvI688RPnUX2o24QE; Wed, 26 Oct 2022 00:44:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1666745072; bh=987aHtuXd3sgY3NdcJAiLbUfCazhSYzHWkUOeetukTE=; h=Received:Received:Message-ID:Date:MIME-Version:Subject:To:From: Content-Type; b=MLgytDSdYVX4AoQL48TzHBw4Q9xHHPoebNwJr0RfaYLTgy1hFYKJHbAzBO5BmozvV eeaMUu/FL3A7ciMq9nKbR7eD0S0Bd18FgcJJX2UELyRqNYvwyXjNjLYL6w55TOqTUq PD6VDuNh8Gtj3NBynHbalT8847IBaej//uGgwaY2Nmi5+OWWqJytFp480AmCpC+ya+ kX9+ByrdySna5/jo8ZvdkTPzsCpX+BS8VUeuR4V0L3lR8qkBBhfCNvHvlvjR/ZyfVL qgXip0OJOd5GXLzdyLFCYbQ8AIK7iFBZkpbv5DO/Bg3ZNlFY5LzC25jbbnEI4cPs0A IVblUlzXxcvfA== Received: from [IPV6:2601:547:c500:dbe:e463:d085:4e8c:9d87] ([IPv6:2601:547:c500:dbe:e463:d085:4e8c:9d87]) by resomta-a1p-077060.sys.comcast.net with ESMTPSA id nUWeoyzDEst3qnUWfo3gsD; Wed, 26 Oct 2022 00:44:10 +0000 X-Xfinity-VMeta: sc=-100.00;st=legit Message-ID: Date: Tue, 25 Oct 2022 20:44:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [ITP] rsync 3.2.6 Content-Language: en-US To: Jon Turney , "cygwin-apps@cygwin.com" , Jari Aalto References: <9fbe1bb3-8da9-0b5d-e695-6f9b24a8b8ee@acm.org> From: Chad Dougherty In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-09 10:23, Jon Turney wrote: > Thanks for looking into updating this.  I'd like to give the existing > maintainer first refusal, though. > Any new thoughts on this? There was a new upstream release, rsync-3.2.7, and I've updated my cygport and its associated artifacts: https://github.com/crd477/cygports/tree/main/rsync >> # Enable this function for releases that work without autoreconf >> src_compile() > > You should only override the default src_compile if it doesn't work. > > The fact that autoreconf isn't apparently necessary, doesn't mean it > should be omitted, since that means that future fixes to the > autoconfiguration machinery aren't automatically incorporated into the > package, but will only appear when upstream updates the autotools used > to generate the distributed autoconfiguration files. > OK, got it. My current cygport no longer skips the cygautoreconf step. Thanks... -- -Chad