From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38823 invoked by alias); 7 Feb 2018 21:03:20 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 38805 invoked by uid 89); 7 Feb 2018 21:03:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=H*u:6.1, H*UA:6.1, risk X-HELO: m0.truegem.net Received: from m0.truegem.net (HELO m0.truegem.net) (69.55.228.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Feb 2018 21:03:16 +0000 Received: (from daemon@localhost) by m0.truegem.net (8.12.11/8.12.11) id w17L3EBM025764 for ; Wed, 7 Feb 2018 13:03:14 -0800 (PST) (envelope-from mark@maxrnd.com) Received: from 76-217-5-154.lightspeed.irvnca.sbcglobal.net(76.217.5.154), claiming to be "[192.168.1.100]" via SMTP by m0.truegem.net, id smtpd3XoWnI; Wed Feb 7 13:03:06 2018 Subject: Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's To: cygwin-apps@cygwin.com References: <59D90AF8D70E9740907BACDE2BCB520836E4AA63@RESW102.resdom01.local> <20180206142012.GB30794@calimero.vinschen.de> <80645451-e2d6-56bf-87c4-c02ac801f201@maxrnd.com> <29e2c298-107a-eb7e-31a9-0b937a7d95db@redhat.com> From: Mark Geisert Message-ID: Date: Wed, 07 Feb 2018 21:03:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00015.txt.bz2 Brian Inglis wrote: > On 2018-02-07 08:38, Eric Blake wrote: >> On 02/07/2018 01:29 AM, Mark Geisert wrote: >>> I don't have libtirpc in git so I'm submitting a text patch. Sorry for any >>> inconvenience. This is Cygwin-specific and against src/bindresvport.c of >>> libtirpc 1.0.1. Unsure if it ought to go upstream; appreciate input on that. >>> Thanks much, >>> >>> ..mark >>> >>> --------8<-------- >>> 35a36,38 >>> > /* On Cygwin prefer Cygwin's bindresvport{,_sa}() to portable version here */ >> >> An ed-script diff is practically useless; without context, it is too easy to >> misapply the patch if the file has been edited differently in the meantime. >> ALWAYS use 'diff -u' (what git does by default) or 'diff -c' when generating a >> patch, so that it has proper context. > > Also mandatory to add -p, --show-c-function for patches, and in general for > directory or recursive patch diffs -N, --new-file so new files are diffed as if > against an empty file; --strip-trailing-cr is useful if some files may have CRs. > Understood. Thanks for the advice. I knowingly took a risk here on the assumption nobody else would be working on this specific file. But with your advice I don't need to take that kind of risk again. And the patch will be more robust too. Cheers, ..mark