From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-045.btinternet.com (mailomta10-sa.btinternet.com [213.120.69.16]) by sourceware.org (Postfix) with ESMTPS id 469873858D20 for ; Tue, 8 Aug 2023 16:02:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 469873858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-004.btmx-prd.synchronoss.net ([10.2.38.7]) by sa-prd-fep-045.btinternet.com with ESMTP id <20230808160242.MGAB29451.sa-prd-fep-045.btinternet.com@sa-prd-rgout-004.btmx-prd.synchronoss.net> for ; Tue, 8 Aug 2023 17:02:42 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 64CAD98C00AD99BA X-Originating-IP: [86.140.112.76] X-OWM-Source-IP: 86.140.112.76 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedviedrledvgdelhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpegtkfffgggfuffvfhfhjgesmhdtreertdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhephefhieegueektdfgfeekleegvdegffdvjeehvefgfffgudevjeffleevtdffkeefnecukfhppeekiedrudegtddrudduvddrjeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdeingdpihhnvghtpeekiedrudegtddrudduvddrjeeipdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepuddprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomhdprhgvvhfkrfephhhoshhtkeeiqddugedtqdduuddvqdejiedrrhgrnhhgvgekiedqudegtddrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgvrhepjhhonhhtuhhrnhgvhiessghtihhnthgvrhhnvghtrdgtohhmpdhgvghokffrpefiuedpoffvtefjohhsthepshgrqdhprhguqdhrghhouhhtqddttdeg X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (86.140.112.76) by sa-prd-rgout-004.btmx-prd.synchronoss.net (5.8.814.02) (authenticated as jonturney@btinternet.com) id 64CAD98C00AD99BA for cygwin-apps@cygwin.com; Tue, 8 Aug 2023 17:02:42 +0100 Content-Type: multipart/mixed; boundary="------------iNfbowOcomXH0ZVGYZLU0S9A" Message-ID: Date: Tue, 8 Aug 2023 17:02:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 0/4] Testsuite update Content-Language: en-GB To: "cygwin-apps@cygwin.com" References: <20230804124723.9236-1-jon.turney@dronecode.org.uk> From: Jon Turney In-Reply-To: X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------iNfbowOcomXH0ZVGYZLU0S9A Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 09:55, Corinna Vinschen wrote: > On Aug 4 13:47, Jon Turney wrote: >> This gets us down to no permanent failures in the testsuite in CI. There is an intermittent failure in kill01, which I need to do something about before turning on taking notice of the testsuite result in CI. Effectively, all this does is: pid = fork(); if (pid == 0) { pause(); } else { kill(pid, SIGKILL); waitpid(pid, &status, 0); } This is quite easy to demonstrate with 'winsup.api/ltp/kill01 -i 1000', which repeats the test, succeeding until it hangs. Looking at the strace output, I would guess it's some race condition where a child process isn't yet in a position to receive a signal immediately after fork() returns in the parent (so the signal is dropped, and the parent blocks indefinitely in waitpid waiting for the child to terminate) I'm not sure if that's fixable (or worth effort), so maybe just adding a small delay in the test is the thing to do... :) --------------iNfbowOcomXH0ZVGYZLU0S9A Content-Type: text/plain; charset=UTF-8; name="0001-Cygwin-testsuite-Add-a-small-delay-in-kill01.patch" Content-Disposition: attachment; filename="0001-Cygwin-testsuite-Add-a-small-delay-in-kill01.patch" Content-Transfer-Encoding: base64 RnJvbSAzYjdkN2FlMGYzYzI5ZGU0ZDhlN2ZmMGQ0NDg3YmM2Zjc5MTNkYzg2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVHVybmV5IDxqb24udHVybmV5QGRyb25lY29k ZS5vcmcudWs+CkRhdGU6IFR1ZSwgOCBBdWcgMjAyMyAxNjozODoyMCArMDEwMApTdWJqZWN0 OiBbUEFUQ0hdIEN5Z3dpbjogdGVzdHN1aXRlOiBBZGQgYSBzbWFsbCBkZWxheSBpbiBraWxs MDEKCkF2b2lkIHRyYW5zaWVudCBmYWlsdXJlcyBieSBhZGRpbmcgYSBzbWFsbCBkZWxheSBh ZnRlciBmb3JrKCktaW5nIHRvCmFsbG93IHRoZSBjaGlsZCB0byBnZXQgaW50byBhIHN0YXRl IHdoZXJlIGl0IGNhbiByZWNpZXZlIHNpZ25hbHMuCi0tLQogd2luc3VwL3Rlc3RzdWl0ZS93 aW5zdXAuYXBpL2x0cC9raWxsMDEuYyB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspCgpkaWZmIC0tZ2l0IGEvd2luc3VwL3Rlc3RzdWl0ZS93aW5zdXAuYXBpL2x0cC9r aWxsMDEuYyBiL3dpbnN1cC90ZXN0c3VpdGUvd2luc3VwLmFwaS9sdHAva2lsbDAxLmMKaW5k ZXggMDQyODk5MTczLi41ODA1M2VlYjggMTAwNjQ0Ci0tLSBhL3dpbnN1cC90ZXN0c3VpdGUv d2luc3VwLmFwaS9sdHAva2lsbDAxLmMKKysrIGIvd2luc3VwL3Rlc3RzdWl0ZS93aW5zdXAu YXBpL2x0cC9raWxsMDEuYwpAQCAtMTAyLDYgKzEwMiw3IEBAIG1haW4oaW50IGFjLCBjaGFy ICoqYXYpCiAJCQkvKk5PVFJFQUNIRUQqLwogCQkJZXhpdChleG5vKTsKIAkJfSBlbHNlIHsK KwkJCVNsZWVwKDEpOwogCQkJVEVTVChraWxsKHBpZCwgVEVTVF9TSUcpKTsKIAkJCXdhaXRw aWQocGlkLCAmc3RhdHVzLCAwKTsKIAkJfQotLSAKMi4zOS4wCgo= --------------iNfbowOcomXH0ZVGYZLU0S9A--