From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id AF835394FC35 for ; Sun, 9 May 2021 19:54:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AF835394FC35 Received: by mail-ed1-x52e.google.com with SMTP id s7so11562974edq.12 for ; Sun, 09 May 2021 12:54:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eFAFPakCn1LQb87dz2fZNWSV8wjP2JaDOUP2VOhSIGI=; b=P8szEpdBeSVFLMf4oO4qexJr8FKI1Gi5HLqk828tHpp3eytChG4NSFw++lnOCUrdlN amiZ/6S72/KvT178DqwnuXcuNCQJi//mdIz/T+AvIJzSvw2OVgefD9Ng+zKfEQPB0/QU J2TXy6Hq2Og8VWFK+ThCQns1nthn8TXMHEyD9ecwex7plXg3kT2a2k7FV6EpwMyV53P8 XBmi8UpNKc9pLXqKV0zxo/QxIuOeCmrJmnn2zMXoKyT/bbcpstotIcFMsoOOUdmA2/r6 /hn/w3q4buyBLlJJI2KxRV9CKNzOJiQijLfD7mj68FxymOpdVOEwiMd+YJSm0hfjAuha 7TMA== X-Gm-Message-State: AOAM533N5C4VeKaMnZP7rVZ9t6Ppt83wubPdyrfFluzwc/lJ28X/X77m XMLeA3hEvIfSuw/Axh3pJVKxLGbxshY= X-Google-Smtp-Source: ABdhPJw+nBnjXhgQU9rEUYp0kGhiu0GJ2N1hibGV6K6fIdpsQStLetx/YB62OlsnA8F+Iu9+8VtCYA== X-Received: by 2002:aa7:c413:: with SMTP id j19mr25634787edq.206.1620590098275; Sun, 09 May 2021 12:54:58 -0700 (PDT) Received: from ?IPv6:2003:cc:9f04:e375:74fd:27ff:a194:4524? (p200300cc9f04e37574fd27ffa1944524.dip0.t-ipconnect.de. [2003:cc:9f04:e375:74fd:27ff:a194:4524]) by smtp.gmail.com with ESMTPSA id b17sm8922303edr.80.2021.05.09.12.54.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 May 2021 12:54:58 -0700 (PDT) Subject: Re: pdfgrep [ITA] To: cygwin-apps@cygwin.com References: <000401d7404f$faa32970$efe97c50$@pdinc.us> <877dkf7hep.fsf@Rainer.invalid> <001001d74052$710751c0$5315f540$@pdinc.us> <017801d74500$4c5eb270$e51c1750$@pdinc.us> From: Marco Atzeri Message-ID: Date: Sun, 9 May 2021 21:54:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <017801d74500$4c5eb270$e51c1750$@pdinc.us> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: it Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 May 2021 19:55:01 -0000 On 09.05.2021 20:22, Jason Pyeron wrote: >>> >>> pull it up to the latest version (2.1.2), > > 2 Issues encountered and mitigated. > > 1. There are some significant changes in the functionality of 2.1.2 vs 1.4.1. > 2. The tool chain has evolved a bit since 2016, so the current 1.4.1-1 release would not build anymore, so I have updated the cygport as release 2. > > So I have built both 1.4.1 and 2.1.2 on Windows Server 2019 with all updates installed. > >>> check the patches for the >>> major Linux distros (if any, Fedora does not for instance) and make sure > > I started with pdfgrep's master branch, so when the next release is made there should not be any surprises. But I did not yet review other distro's patches. I can make master branch builds available as test marked packages, but need guidance on version number and release numbering first. > > I have not pushed my changes outside of my private repo, as I expect that there will be some editorial change requests along with any additional patching. > >>> it works on both 32bit and 64bit architecture and show the result. > > How should I force cygport to run `make check`? In other words how do I link the `cygport test` command to `make check` ? I read the cygport docs, but README and html/manual/src_test_cygpart.html were not helpful. > `cygport pdfgrep.cygport check` will run make check. the default test method is src_test() { cd ${B} cygmake check } On my build, it is all failing and the binary itself is not really functional $ ./pdfgrep.exe --help terminate called after throwing an instance of 'std::runtime_error' what(): locale::facet::_S_create_c_locale name not valid Aborted (core dumped) Same for your binary May be some other patches are needed ? General suggestion: - add BUILD_REQUIRES="libpcre-devel libgcrypt-devel libpoppler-cpp-devel" the test suite seems to need tcl so you may need to add more packages