From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-046.btinternet.com (mailomta4-re.btinternet.com [213.120.69.97]) by sourceware.org (Postfix) with ESMTPS id 1A2EE3858C74 for ; Tue, 1 Feb 2022 15:05:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A2EE3858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-004.btmx-prd.synchronoss.net ([10.2.54.7]) by re-prd-fep-046.btinternet.com with ESMTP id <20220201150508.ZRGF24326.re-prd-fep-046.btinternet.com@re-prd-rgout-004.btmx-prd.synchronoss.net> for ; Tue, 1 Feb 2022 15:05:08 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613A901C12D2C358 X-Originating-IP: [81.129.146.209] X-OWM-Source-IP: 81.129.146.209 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvvddrgeefgdejvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpedvtdetffekveevjeegheeglefhtdeggfeilefggfdutedufedvgefgieeiffdtveenucfkphepkedurdduvdelrddugeeirddvtdelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdefngdpihhnvghtpeekuddruddvledrudegiedrvddtledpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedupdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhm X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.103] (81.129.146.209) by re-prd-rgout-004.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613A901C12D2C358 for cygwin-apps@cygwin.com; Tue, 1 Feb 2022 15:05:08 +0000 Message-ID: Date: Tue, 1 Feb 2022 15:04:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: cygport problem with pkg name starting with number Content-Language: en-GB To: "cygwin-apps@cygwin.com" References: From: Jon Turney In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3569.0 required=5.0 tests=BAYES_00, BODY_8BITS, FORGED_SPF_HELO, KAM_ASCII_DIVIDERS, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 15:05:15 -0000 On 30/01/2022 19:44, Marco Atzeri wrote: > It is not a huge number of case as we have only two packages > in this category 4ti2 and 2048-cli > > on   /usr/share/cygport/lib/pkg_pkg.cygpart > > there is this code using indirect variable assignment > as ${!dbg_contents_var} > > ------------------------------------------------------------------ >         local dbg_contents_var=${PN//[-+\.]/_}_debuginfo_CONTENTS; > >         __step "${PN}-debuginfo-${PVR}.tar.xz"; >         mkdir -p ${distdir}/${PN}/${PN}-debuginfo; >         tar Jcvf > ${distdir}/${PN}/${PN}-debuginfo/${PN}-debuginfo-${PVR}.tar.xz \ >             usr/*/debug/ ${autoloaddir} ${!dbg_contents_var} \ >             | tee ${T}/.${PN}-debuginfo.lst \ >             || error "Debuginfo package creation failed: ${PN}-debuginfo" > > ------------------------------------------------------------------ > > that produces > > /usr/share/cygport/lib/pkg_pkg.cygpart: line 197: > 4ti2_debuginfo_CONTENTS: bad substitution > > Any idea how to overcome the issue in cygport code ? I wonder how this worked the last time the package was built (in 2016!) I guess since this variable is not exposed to the user, you could just rename it so it starts with a '_'. But, it looks like there would be a general problem if anything in PKG_NAMES starts with a digit, as you wouldn't be able to assign to _CONTENTS etc. in your cygport? > Of course I can just rename the package lib4ti2 and solve the issue ;-) I wonder if forbidding package names to start with a digit is the solution :)