From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-045.btinternet.com (mailomta21-re.btinternet.com [213.120.69.114]) by sourceware.org (Postfix) with ESMTPS id 3FC483858D37 for ; Tue, 23 Aug 2022 15:20:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3FC483858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.54.5]) by re-prd-fep-045.btinternet.com with ESMTP id <20220823152055.GUGO3219.re-prd-fep-045.btinternet.com@re-prd-rgout-002.btmx-prd.synchronoss.net>; Tue, 23 Aug 2022 16:20:55 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613A8DE835FCC2E3 X-Originating-IP: [86.139.158.127] X-OWM-Source-IP: 86.139.158.127 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeiledgkeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpedvtdetffekveevjeegheeglefhtdeggfeilefggfdutedufedvgefgieeiffdtveenucfkphepkeeirddufeelrdduheekrdduvdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdehngdpihhnvghtpeekiedrudefledrudehkedruddvjedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepvehhrhhishhtihgrnhdrhfhrrghnkhgvsehtqdhonhhlihhnvgdruggvpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhm X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.105] (86.139.158.127) by re-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613A8DE835FCC2E3; Tue, 23 Aug 2022 16:20:55 +0100 Message-ID: Date: Tue, 23 Aug 2022 16:20:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH setup] Add new option --chown-admin Content-Language: en-GB To: Christian Franke , "cygwin-apps@cygwin.com" References: <3096f251-d7ca-073b-d7d7-751b7fe3e8c1@t-online.de> <405df5c6-ce47-0254-ae4d-4a23ff3533d5@dronecode.org.uk> <5b45ccdc-da32-ff11-037f-c00828f397c5@dronecode.org.uk> <32655945-5075-0823-2a1d-b72caa4b7791@t-online.de> From: Jon Turney In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3567.4 required=5.0 tests=BAYES_00, BODY_8BITS, FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2022 15:20:57 -0000 On 12/07/2022 13:50, Jon Turney wrote: > [Replying to the right list this time...] > On 09/07/2022 13:21, Christian Franke wrote: [...] >> >> The UserSettings ctor has a somewhat hidden side effect which sets >> root_scope correctly: >> >>   UserSettings::UserSettings(...); >>    open_settings("setup.rc", ...); >>     io_stream::open("cygfile:///etc/setup/setup.rc", ...); >>      io_stream_cygfile::io_stream_cygfile("/etc/setup/setup.rc", ...); >>       get_root_dir_now(); >>        read_mounts(""); >>         read_mounts_nt(""); >>          root_scope = isuser ? IDC_ROOT_USER : IDC_ROOT_SYSTEM; >> >> Conclusion: Regression introduced Feb 24, 2012 (befc9dd). >> > > Thanks for tracking this down. > > That just seems... fractally wrong. I kind of lost track of this. Is there anything else needed to fix the original problem here? Or is it solved by the change to defer setting the group until after root_scope is known?