From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15261 invoked by alias); 30 Aug 2016 23:29:06 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 15250 invoked by uid 89); 30 Aug 2016 23:29:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=views, View, perfect, Hx-spam-relays-external:ESMTPA X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Aug 2016 23:28:55 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0607420410 for ; Tue, 30 Aug 2016 19:28:54 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 30 Aug 2016 19:28:54 -0400 Received: from [192.168.1.102] (host31-51-206-108.range31-51.btcentralplus.com [31.51.206.108]) by mail.messagingengine.com (Postfix) with ESMTPA id A23D0F29CD for ; Tue, 30 Aug 2016 19:28:53 -0400 (EDT) Subject: Re: [PATCH setup 4/4] Use a drop-down list to directly select chooser view filter To: cygwin-apps@cygwin.com References: <20160829100417.153392-1-jon.turney@dronecode.org.uk> <20160830130122.GB28244@calimero.vinschen.de> From: Jon Turney Message-ID: Date: Tue, 30 Aug 2016 23:29:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160830130122.GB28244@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00112.txt.bz2 On 30/08/2016 14:01, Corinna Vinschen wrote: > On Aug 29 11:04, Jon Turney wrote: >> Rather than a button for cycling through views, use a drop-down list to >> choose the view >> >> Remove not very useful PickView::views::Unknown enum value so that enum can >> start from 0, so it can be used directly as a drop-down list index. > > Almost Perfect. Please apply, without the colon after "View" (compare > with "Search"). Done. > What still bugs me is that the static text elements do not vertically > align with the texts in the input elements. I. e., the word "View" is a > dot or two lower than, say, the word "Category" in the drop down menu. > Same for "Search" and the input field. Can we fix this easily? Any > such patch is pre-approved. I don't quite understand why the text doesn't look centered on the control at the moment. The controls are the standard 14 DLUs high, 1 vertical DLU = 1/8th of the average character height, and (14 - 8)/2 = 3 DLUs is used as the offset between the top of the control and the top of the label.