From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59130 invoked by alias); 7 Dec 2017 20:46:42 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 59120 invoked by uid 89); 7 Dec 2017 20:46:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=click, HContent-Transfer-Encoding:8bit X-HELO: limerock01.mail.cornell.edu Received: from limerock01.mail.cornell.edu (HELO limerock01.mail.cornell.edu) (128.84.13.241) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Dec 2017 20:46:40 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id vB7Kkb8n014391 for ; Thu, 7 Dec 2017 15:46:38 -0500 Received: from [192.168.0.4] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id vB7KkaPL018547 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Thu, 7 Dec 2017 15:46:37 -0500 Subject: Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT To: cygwin-apps@cygwin.com References: <20171204155855.9484-1-kbrown@cornell.edu> <99be290c-6134-9bb9-6231-b0635a1e3fe9@cornell.edu> <5695aabd-2952-3ce7-9a5d-bd47afd4f849@cornell.edu> <395035be-4ef6-fbb4-4644-5a4b21f3b3ea@dronecode.org.uk> From: Ken Brown Message-ID: Date: Thu, 07 Dec 2017 20:46:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <395035be-4ef6-fbb4-4644-5a4b21f3b3ea@dronecode.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00043.txt.bz2 On 12/7/2017 1:35 PM, Jon Turney wrote: > On 05/12/2017 17:32, Ken Brown wrote: >> On 12/5/2017 11:03 AM, Ken Brown wrote: >>> On 12/5/2017 7:58 AM, Jon Turney wrote: >>>> The search textbox on the package chooser page needs the same fix. >>> >>> It's not immediately clear to me how to do this, since I don't know >>> what the default pushbutton should be while the user is typing in the >>> search box. >>> >>> One possibility is to convert the label "Search" to the left of the >>> box to a SEARCH pushbutton, whose effect is to call OnTimerMessage(). >>> If we make this the default, then pressing Enter will cause the >>> search filter to immediately take effect, which is probably what the >>> user expects. > > It seems a bit weird to have a button which automatically pushes itself > half a second after you finish typing. > > Attached is my attempt, which (ab)uses an invisible button. I agree, this is better than my version. >> Something like the attached?  This might not be quite right, because >> the previous default button is never restored.  I'm not sure how >> important that is. > > I think it's something that should be done, if possible, so I added that. In my testing, 'Next' does indeed become the default button after I click outside of the textbox, but there's no visual indication of this. The MSDN page for DM_SETDEFID (https://msdn.microsoft.com/en-us/library/windows/desktop/ms645413(v=vs.85).aspx) mentions a different situation where button highlighting doesn't accurately reflect the default button. In that case it suggests sending a BM_SETSTYLE message to change the border style. I looked at the documentation for BM_SETSTYLE, but it wasn't obvious to me what do do. Ken