From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout06.t-online.de (mailout06.t-online.de [194.25.134.19]) by sourceware.org (Postfix) with ESMTPS id F20EE38485B8 for ; Sat, 9 Jul 2022 15:59:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F20EE38485B8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=t-online.de Received: from fwd84.dcpf.telekom.de (fwd84.aul.t-online.de [10.223.144.110]) by mailout06.t-online.de (Postfix) with SMTP id AB2E3A5B9 for ; Sat, 9 Jul 2022 17:59:31 +0200 (CEST) Received: from [192.168.2.102] ([87.187.34.65]) by fwd84.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1oACri-296lo80; Sat, 9 Jul 2022 17:59:30 +0200 From: Christian Franke Subject: [PATCH setup] Add new option --no-write-registry To: cygwin-apps@cygwin.com Message-ID: Date: Sat, 9 Jul 2022 17:59:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 SeaMonkey/2.53.12 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------A3CACD84B41F4BB22E4D1721" X-TOI-EXPURGATEID: 150726::1657382370-0143F118-B36D16D7/0/0 CLEAN NORMAL X-TOI-MSGID: 4a134106-4283-482e-8315-d443272e4fcb X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jul 2022 15:59:35 -0000 This is a multi-part message in MIME format. --------------A3CACD84B41F4BB22E4D1721 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit IMO useful for temporary test installs or "portable" installs to USB devices. The 0002-patch adds a related log message. BTW: During testing I found that the "All Users" <> "Just Me" GUI setting has no effect at all. If setup is run elevated, "All Users" is always implied. This is likely because read_mounts() is called again after the "Root" dialog. It resets root_scope and does not re-read the registry. read_mounts (const std::string val) { ...   root_scope = (nt_sec.isRunAsAdmin ())? IDC_ROOT_SYSTEM : IDC_ROOT_USER; ... } -- Regards, Christian --------------A3CACD84B41F4BB22E4D1721 Content-Type: text/plain; charset=UTF-8; name="0001-Add-new-option-no-write-registry.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Add-new-option-no-write-registry.patch" RnJvbSBhYjNjOTRlYmYwZTc4NjA2YzM2NjBiZWM4ZTBjMDRjNmU2YjhkZGQ0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRnJhbmtlIDxjaHJpc3RpYW4uZnJh bmtlQHQtb25saW5lLmRlPgpEYXRlOiBTYXQsIDkgSnVsIDIwMjIgMTY6NTI6NDcgKzAyMDAK U3ViamVjdDogW1BBVENIIDEvMl0gQWRkIG5ldyBvcHRpb24gLS1uby13cml0ZS1yZWdpc3Ry eQoKSWYgc3BlY2lmaWVkLCB0aGUgcm9vdGRpciBpcyBub3Qgd3JpdHRlbiB0byB0aGUgcmVn aXN0cnkgYW5kIG5vCnJlZ2lzdHJ5IGtleSBpcyBjcmVhdGVkLgotLS0KIGluc3RhbGwuY2Mg fCA2ICsrKystLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9pbnN0YWxsLmNjIGIvaW5zdGFsbC5jYwppbmRleCAxZmRj Njk5Li5lYjdiMWIyIDEwMDY0NAotLS0gYS9pbnN0YWxsLmNjCisrKyBiL2luc3RhbGwuY2MK QEAgLTcwLDYgKzcwLDcgQEAgc3RhdGljIGxvbmcgbG9uZyBpbnQgdG90YWxfYnl0ZXNfc29m YXIgPSAwOwogc3RhdGljIGludCBwYWNrYWdlX2J5dGVzID0gMDsKIAogc3RhdGljIEJvb2xP cHRpb24gTm9SZXBsYWNlT25SZWJvb3QgKGZhbHNlLCAncicsICJuby1yZXBsYWNlb25yZWJv b3QiLCBJRFNfSEVMUFRFWFRfTk9fUkVQTEFDRU9OUkVCT09UKTsKK3N0YXRpYyBCb29sT3B0 aW9uIE5vV3JpdGVSZWdpc3RyeSAoZmFsc2UsICdcMCcsICJuby13cml0ZS1yZWdpc3RyeSIg LyosIFRPRE86IElEU19IRUxQVEVYVF8uLi4gKi8pOwogCiBzdHJ1Y3Qgc3RkX2RpcnNfdCB7 CiAgIGNvbnN0IGNoYXIgKm5hbWU7CkBAIC04MzMsOCArODM0LDkgQEAgZG9faW5zdGFsbF90 aHJlYWQgKEhJTlNUQU5DRSBoLCBIV05EIG93bmVyKQogICBpbnQgZGYgPSBkaXNrZnVsbCAo Z2V0X3Jvb3RfZGlyICgpLmNfc3RyKCkpOwogICBQcm9ncmVzcy5TZXRCYXIzIChkZik7CiAK LSAgLyogV3JpdGVzIEN5Z3dpbi9zZXR1cC9yb290ZGlyIHJlZ2lzdHJ5IHZhbHVlICovCi0g IGNyZWF0ZV9pbnN0YWxsX3Jvb3QgKCk7CisgIGlmICghTm9Xcml0ZVJlZ2lzdHJ5KQorICAg IC8qIFdyaXRlcyBDeWd3aW4vc2V0dXAvcm9vdGRpciByZWdpc3RyeSB2YWx1ZSAqLworICAg IGNyZWF0ZV9pbnN0YWxsX3Jvb3QgKCk7CiAKICAgc3RkOjp2ZWN0b3IgPHBhY2thZ2V2ZXJz aW9uPiBpbnN0YWxsX3EsIHVuaW5zdGFsbF9xLCBzb3VyY2VpbnN0YWxsX3E7CiAKLS0gCjIu MzYuMQoK --------------A3CACD84B41F4BB22E4D1721 Content-Type: text/plain; charset=UTF-8; name="0002-Log-writes-to-rootdir-registry-entry.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0002-Log-writes-to-rootdir-registry-entry.patch" RnJvbSA0NjdiMzBlMTllNTA2ZWNiNGIxZTllZDljNGQ3NTI4ZDc3ZGIwMjI4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRnJhbmtlIDxjaHJpc3RpYW4uZnJh bmtlQHQtb25saW5lLmRlPgpEYXRlOiBTYXQsIDkgSnVsIDIwMjIgMTY6NTc6MzEgKzAyMDAK U3ViamVjdDogW1BBVENIIDIvMl0gTG9nIHdyaXRlcyB0byByb290ZGlyIHJlZ2lzdHJ5IGVu dHJ5CgotLS0KIG1vdW50LmNjIHwgNiArKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9tb3VudC5jYyBiL21vdW50LmNjCmluZGV4IGY2M2Vk ZDQuLjAxMzYzOTYgMTAwNjQ0Ci0tLSBhL21vdW50LmNjCisrKyBiL21vdW50LmNjCkBAIC0x MzUsNiArMTM1LDEyIEBAIGNyZWF0ZV9pbnN0YWxsX3Jvb3QgKCkKICAgICBtYm94IChOVUxM LCBJRFNfTU9VTlRfUkVHSVNUUllfS0VZX0ZBSUxFRCwgTUJfT0sgfCBNQl9JQ09OV0FSTklO Ryk7CiAgIFJlZ0Nsb3NlS2V5IChrZXkpOwogCisgIExvZyAoTE9HX1RJTUVTVEFNUCkgPDwg IlJlZ2lzdHJ5IHZhbHVlIHNldDogSEtFWV8iCisJCSAgICAgIDw8IChyb290X3Njb3BlID09 IElEQ19ST09UX1VTRVIgPyAiQ1VSUkVOVF9VU0VSXFwiCisJCQkJCQkgICAgICA6ICJMT0NB TF9NQUNISU5FXFwiKQorCQkgICAgICA8PCBidWYgPDwgIlxccm9vdGRpciA9IFwiIiA8PCBn ZXRfcm9vdF9kaXIgKCkgPDwgIlwiIgorCQkgICAgICA8PCBlbmRMb2c7CisKICAgLy8gVGhl IG1vdW50IHRhYmxlIGlzIGFscmVhZHkgaW4gdGhlIHJpZ2h0IHNoYXBlIGF0IHRoaXMgcG9p bnQuCiAgIC8vIFJlYWRpbmcgaXQgYWdhaW4gaXMgbm90IG5lY2Vzc2FyeS4KICAgLy9yZWFk X21vdW50cyAoc3RkOjpzdHJpbmcgKCkpOwotLSAKMi4zNi4xCgo= --------------A3CACD84B41F4BB22E4D1721--