From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: Re: [Bug] Re3gression in setup handling of SHA512 checksum failures
Date: Thu, 22 Mar 2018 14:42:00 -0000 [thread overview]
Message-ID: <e8bb17a3-a4fd-802a-40dc-35f1376ccafa@cornell.edu> (raw)
In-Reply-To: <324dcde5-cc75-faf7-3cc5-5fece0c7057b@SystematicSw.ab.ca>
On 3/21/2018 8:35 PM, Brian Inglis wrote:
> On 2018-03-21 12:14, Ken Brown wrote:
>> On 3/20/2018 4:11 PM, Achim Gratz wrote:
>>> Ken Brown writes:
>>>> I'll look into both of these issues, unless Jon beats me to it.
>>>
>>> Thanks.
>>>
>>>> By the way, this only affects local installs. For network installs,
>>>> the hash gets checked at an earlier stage.
>>>
>>> That's correct. I forgot to mention that, but all my installs are from
>>> a local mirror (necessary due to the way network access is restricted at
>>> my workplace)
>>
>> I haven't been able to come up with a safe way to recover from a checksum error
>> at this point, at least not without a lot of work. I propose that we just bail
>> out with an appropriate error message in this situation.
>>
>> Patch attached.
>
> Skipping a single package install is likely to be /relatively/ safe, but if this
> patch causes setup to exit sometime after upgrading a bunch of packages but
> before upgrading another bunch of packages, it could leave Cygwin unusable,
> especially if there are upgrade dependencies between the packages installed
> prior and not installed after the problematic download.
>
> It would be better in such cases to check all the hashes before proceeding with
> any of the installs
We already do that. My patch deals with the situation where we find a
corrupt file during this process.
Ken
next prev parent reply other threads:[~2018-03-22 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 18:23 Achim Gratz
2018-03-20 20:01 ` Ken Brown
2018-03-20 20:11 ` Achim Gratz
2018-03-21 19:30 ` Ken Brown
2018-03-22 0:35 ` Brian Inglis
2018-03-22 14:42 ` Ken Brown [this message]
2018-03-23 2:37 ` Brian Inglis
2018-03-22 22:01 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8bb17a3-a4fd-802a-40dc-35f1376ccafa@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).