From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT
Date: Fri, 08 Dec 2017 14:47:00 -0000 [thread overview]
Message-ID: <ed3d4dfa-582e-da72-72f0-11901ea3cd24@cornell.edu> (raw)
In-Reply-To: <6eadd680-539d-87a4-841b-b6c837815d4d@SystematicSw.ab.ca>
On 12/7/2017 11:55 PM, Brian Inglis wrote:
> On 2017-12-07 13:46, Ken Brown wrote:
>> On 12/7/2017 1:35 PM, Jon Turney wrote:
>>> On 05/12/2017 17:32, Ken Brown wrote:
>>>> On 12/5/2017 11:03 AM, Ken Brown wrote:
>>>>> On 12/5/2017 7:58 AM, Jon Turney wrote:
>>>>>> The search textbox on the package chooser page needs the same fix.
>>>>> It's not immediately clear to me how to do this, since I don't know what the
>>>>> default pushbutton should be while the user is typing in the search box.
>>>>> One possibility is to convert the label "Search" to the left of the box to a
>>>>> SEARCH pushbutton, whose effect is to call OnTimerMessage(). If we make this
>>>>> the default, then pressing Enter will cause the search filter to immediately
>>>>> take effect, which is probably what the user expects.
>>> It seems a bit weird to have a button which automatically pushes itself half a
>>> second after you finish typing.
>>> Attached is my attempt, which (ab)uses an invisible button.
>> I agree, this is better than my version.
>>>> Something like the attached? This might not be quite right, because the
>>>> previous default button is never restored. I'm not sure how important that is.
>>> I think it's something that should be done, if possible, so I added that.
>> In my testing, 'Next' does indeed become the default button after I click
>> outside of the textbox, but there's no visual indication of this.
>> The MSDN page for DM_SETDEFID
>> (https://msdn.microsoft.com/en-us/library/windows/desktop/ms645413(v=vs.85).aspx) mentions
>> a different situation where button highlighting doesn't accurately reflect the
>> default button. In that case it suggests sending a BM_SETSTYLE message to
>> change the border style.
>> I looked at the documentation for BM_SETSTYLE, but it wasn't obvious to me what
>> do do.
>
> Seems like you want to change the button state not style - checking around you
> might want to use Button_SetState macro or BM_SETSTATE message TRUE to
> highlight, FALSE to reset:
>
> https://msdn.microsoft.com/en-us/library/windows/desktop/bb849168(v=vs.85).aspx
>
> with Button_SetStyle macro or BM_SETSTYLE message style BS_DEFPUSHBUTTON |
> BS_CENTER | BS_VCENTER | BS_TEXT | ... as appropriate, so that ENTER works like
> a click:
>
> https://msdn.microsoft.com/en-us/library/windows/desktop/bb775951(v=vs.85).aspx
Thanks for the suggestions, but I tried various BM_SETSTATE and
BM_SETSTYLE messages, and I couldn't find anything that worked: 'Next'
remained unhighlighted.
Ken
next prev parent reply other threads:[~2017-12-08 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 15:59 Ken Brown
2017-12-05 12:58 ` Jon Turney
2017-12-05 16:03 ` Ken Brown
2017-12-05 17:32 ` Ken Brown
2017-12-07 18:35 ` Jon Turney
2017-12-07 20:46 ` Ken Brown
2017-12-08 4:55 ` Brian Inglis
2017-12-08 14:47 ` Ken Brown [this message]
2017-12-08 15:55 ` Jon Turney
2017-12-08 15:48 ` Jon Turney
2017-12-08 16:14 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3d4dfa-582e-da72-72f0-11901ea3cd24@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).