From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m0.truegem.net (m0.truegem.net [69.55.228.47]) by sourceware.org (Postfix) with ESMTPS id 8FAD73858C2C for ; Fri, 25 Mar 2022 08:24:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8FAD73858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maxrnd.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=maxrnd.com Received: (from daemon@localhost) by m0.truegem.net (8.12.11/8.12.11) id 22P8OsxR016018 for ; Fri, 25 Mar 2022 01:24:54 -0700 (PDT) (envelope-from mark@maxrnd.com) Received: from 162-235-43-67.lightspeed.irvnca.sbcglobal.net(162.235.43.67), claiming to be "[192.168.1.100]" via SMTP by m0.truegem.net, id smtpdzXwR2u; Fri Mar 25 00:24:49 2022 Subject: Re: [ITP] cygfuse To: Cygwin-Apps References: <10fcc7c4-0822-0dd8-527e-e46e79e2f031@dronecode.org.uk> From: Mark Geisert Message-ID: Date: Fri, 25 Mar 2022 01:24:49 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.4 MIME-Version: 1.0 In-Reply-To: <10fcc7c4-0822-0dd8-527e-e46e79e2f031@dronecode.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 08:24:59 -0000 Hi Jon, Thanks for the helpful review comments. More below. Jon Turney wrote: > On 10/03/2022 06:16, Mark Geisert wrote: [...]> A few small comments on the cygport file > >> HOMEPAGE="https://github.com/mgeisert/cygfuse" >> #SRC_URI="http://maxrnd.com/~mark/cygwin/x86_64/release/cygfuse/cygfuse-${PV}.tar.xz" >> >> #NOT YET: GIT_URI="https://github.com/mgeisert/cygfuse.git" >> #NOT YET: GIT_TAG="v$VERSION" >> #NOT YET:    inherit git > > It's unclear where the upstream source tarball comes from... Things were in flux and are now straightened out. There's just a SRC_URI now. >> >> # take over these activities from cygport.. >> _CYGPORT_RESTRICT_strip_=1 > > This should be written 'RESTRICT=strip', I think. Yep, thanks. >> src_compile() >> { >>     # fix source tree glitch.. (maybe 'prep' stumbling or bad tarfile layout?) >>     if [ -e ${S}/src ]; then >>     mv ${S}/src/cygfuse ${S} >>     rmdir ${S}/src >>     fi > > I think this can be handled with 'SRC_DIR=src/cygfuse' (and suitable adjustment to > paths throughout) I had tried several variations on this before the initial ITP post. I tried again after your comment. I'm still having issues with source layout. I think my trouble is I'm bootstrapping my own source tree and there seem to be conventions (that I don't know) on how it should be laid out. It seems the source tarball generated by cygport doesn't match the layout of my own source tree. Should my original source be in directory "src" or "src/cygfuse"? If the latter, should there be a version number as part of the directory name? Should my original source be placed under "origsrc" or "src"? These questions pertain to layout before cygport is run to generate the first-ever package tarballs. Currently the build, install, package steps seem to run to completion. But doing a fetch and prep of the tarball has got me stymied (in the prep step). Error is SRC_DIR is not correctly defined I have been perusing /usr/share/cygport/*.cygpart but haven't found a solution. Thanks, ..mark