From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90137 invoked by alias); 26 Aug 2016 14:41:54 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 89670 invoked by uid 89); 26 Aug 2016 14:41:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=shortcut, clicked, View, Hx-spam-relays-external:ESMTPA X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Aug 2016 14:41:44 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id AEC5B206BE for ; Fri, 26 Aug 2016 10:41:41 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Fri, 26 Aug 2016 10:41:41 -0400 Received: from [192.168.1.102] (host31-51-206-108.range31-51.btcentralplus.com [31.51.206.108]) by mail.messagingengine.com (Postfix) with ESMTPA id 5DC68F29CF for ; Fri, 26 Aug 2016 10:41:41 -0400 (EDT) Subject: Re: [PATCH setup 0/4] Use a pop-up menu to select chooser view filter To: cygwin-apps@cygwin.com References: <20160824141537.34836-1-jon.turney@dronecode.org.uk> <20160824165037.GA9783@calimero.vinschen.de> <62665e05-fe7c-1aa0-29bd-9342d90ab29a@dronecode.org.uk> <20160826080704.GB23935@calimero.vinschen.de> From: Jon Turney Message-ID: Date: Fri, 26 Aug 2016 14:41:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160826080704.GB23935@calimero.vinschen.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2016-08/txt/msg00093.txt.bz2 On 26/08/2016 09:07, Corinna Vinschen wrote: > On Aug 25 15:34, Yaakov Selkowitz wrote: >> On 2016-08-25 14:11, Jon Turney wrote: >>> On 24/08/2016 17:50, Corinna Vinschen wrote: >>>> One question: Usually the popup menu itself reflects the current choice. >>>> So, wouldn't it make more sense to have the text "View" just as plain >>>> text to the left, and the actual popup menu next right to it, showing >>>> the current choice? Yes? No? Shut up? >>> >>> Yeah, there is probably better visual language to be used here. >>> >>> If the popup menu itself reflects the current choice, perhaps we don't >>> need a caption with the current choice at all (i.e. just a button that >>> says "View" and that's all...) >>> >>> I'd really like that button to have a '▾' to indicate it has a >>> drop-down, but that seems hard to achieve. >>> >>> (This might be done with the BS_SPLITBUTTON style (which combines a >>> button and dropdown menu), but that is sadly only supported by common >>> controls on Vista or later.) Two more patches follow this mail, which do that. I'm still not totally happy with this. It could give the impression that something is supposed to happen when the "View" part of the the button is clicked, and there is no keyboard shortcut to open the view selection menu. >> We're dropping Cygwin support for XP anyway, so why not from the installer >> as well? > > ACK. I guess so, if a splitbutton is the right solution. Should this be done using ld flags --major-os-version 6 --minor-os-version 0? Or some sort of runtime check?