From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout03.t-online.de (mailout03.t-online.de [194.25.134.81]) by sourceware.org (Postfix) with ESMTPS id F3C1F385841F for ; Tue, 4 Oct 2022 11:50:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3C1F385841F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=t-online.de Received: from fwd86.dcpf.telekom.de (fwd86.aul.t-online.de [10.223.144.112]) by mailout03.t-online.de (Postfix) with SMTP id 04E3277B4; Tue, 4 Oct 2022 13:50:30 +0200 (CEST) Received: from [192.168.2.101] ([79.230.173.42]) by fwd86.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1ofgRR-0WZTAu0; Tue, 4 Oct 2022 13:50:29 +0200 Subject: Re: [Bug] setup regression To: Jon Turney , "cygwin-apps@cygwin.com" , Achim Gratz References: <87leqcocft.fsf@Rainer.invalid> <87h710obeh.fsf@Rainer.invalid> <87tu4z5owu.fsf@Rainer.invalid> <395d4def-71a5-c144-710f-772e64e5e93b@dronecode.org.uk> <835077d9-a870-fb4d-68dc-820d0838d1bb@t-online.de> <4d751290-09dd-b9c5-fcd1-aaf09b1aba89@t-online.de> <861e906d-0eef-abc8-2518-f1d32276bcd7@dronecode.org.uk> From: Christian Franke Message-ID: Date: Tue, 4 Oct 2022 13:50:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 SeaMonkey/2.53.12 MIME-Version: 1.0 In-Reply-To: <861e906d-0eef-abc8-2518-f1d32276bcd7@dronecode.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TOI-EXPURGATEID: 150726::1664884229-D9A4E9D3-F0E37670/0/0 CLEAN NORMAL X-TOI-MSGID: 38dd9837-aaf6-45f1-93dc-1c0f5867bc9d X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jon Turney wrote: > On 27/09/2022 14:51, Christian Franke wrote: >> Christian Franke wrote: >>> ... >>> I made the false assumption that default_version=empty in >>> set_action() always implies that the default version is not >>> accessible. This is not the case for packages selected for >>> installation before chooser is visible. >>> >>> I'm working on a new fix for the "Ctrl+I pressed but current version >>> is not accessible" case. ... >> >> See attached patch. It also fixes the same problem for the "Category" >> view. Testing shows that the problem only affects the display of the >> version number as the solver later silently removes such install >> requests. >> >> >>> The correct logic is already in toggle_action(): Install the most >>> recent accessible non-test ('naively_preferred') version. >>> >> >> I dropped this idea and aligned Ctrl+I behavior with "Install" from >> "Category" view instead. Toggle_action() behaves different in such >> corner cases as it always installs something. > > Thanks, I applied both patches. > > Do you have a simple way of causing a non-accessible package for > testing with? Unfortunately there is only a simple one if the current installation and cache directory matches some conditions. The "Ignore install requests if version is not accessible" case appears if: - "Install from Local Directory" is selected. - A previous version of a no longer installed package is still in the cache directory. Otherwise the package would not appear in the chooser. - The current version of this package is not in the cache directory. The "Size" column shows "?" for such packages. Without commit 63a2c90, Ctrl+I or "Install" from "Category" view shows an empty version in "New" column. The "Install" from "Category" case could also be reproduced with setup 2.919. With this commit, the Install request does nothing.