From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-048.btinternet.com (mailomta23-re.btinternet.com [213.120.69.116]) by sourceware.org (Postfix) with ESMTPS id DD9903858C83 for ; Sun, 23 Apr 2023 13:35:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD9903858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.54.8]) by re-prd-fep-048.btinternet.com with ESMTP id <20230423133521.QWAV25570.re-prd-fep-048.btinternet.com@re-prd-rgout-005.btmx-prd.synchronoss.net>; Sun, 23 Apr 2023 14:35:21 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 63FE9B95061DF130 X-Originating-IP: [86.140.112.72] X-OWM-Source-IP: 86.140.112.72 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtkedgieejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepgfeludfggefhteetueelieeltddufeevieduiefgudelueektdeutefftedvheejnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepkeeirddugedtrdduuddvrdejvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkeeirddugedtrdduuddvrdejvddpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepsghoohhlvggrnhhlrggsvghlsehgmhgrihhlrdgtohhmpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhmpdhrvghvkffrpehhohhsthekiedqudegtddqudduvddqjedvrdhrrghnghgvkeeiqddugedtrdgsthgtvghnthhrrghlphhluhhsrdgtohhmpdgruhhthhgpuhhsvghrpehjohhnthhurhhnvgihsegsthhinhhtvghrnhgvthdr tghomhdpghgvohfkrfepifeupdfovfetjfhoshhtpehrvgdqphhrugdqrhhgohhuthdqtddthe X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (86.140.112.72) by re-prd-rgout-005.btmx-prd.synchronoss.net (5.8.814) (authenticated as jonturney@btinternet.com) id 63FE9B95061DF130; Sun, 23 Apr 2023 14:35:21 +0100 Message-ID: Date: Sun, 23 Apr 2023 14:35:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [ITA] ruby 3.2.2 To: Daisuke Fujimura , "cygwin-apps@cygwin.com" References: <55c06590-b192-9c43-c20f-a1967abf920c@gmail.com> <8a06d928-4788-2290-581b-f22f881af7b2@dronecode.org.uk> Content-Language: en-GB From: Jon Turney In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/04/2023 13:04, Daisuke Fujimura via Cygwin-apps wrote: >>>>>> Are you planning to adopt also the ruby-* sub-packages ? > > I intend to do that. > > >>> 2. Modify cygport and release it. >>> - Add code to detect dependencies on `ruby_xy`. >>> - It is similar to the process for `perl5_xy0`. >>> - https://github.com/cygwin/cygport/blob/0.36.2/lib/pkg_info.cygpart#L442 >>> - https://github.com/cygwin/cygport/blob/0.36.2/lib/pkg_info.cygpart#L639 >> >> Yes. >> >> I'm not asking you to do this work though, unless you really feel like it :) > > Please review the attached diff. That looks like almost exactly what's needed. Thank you very much for that! >>> - Add `ruby_PROVIDES="ruby_${${VERSION%.*}//./}"` to ruby.cygport. > > ``` > /tmp/cygport-ruby/ruby.cygport: line 49: ${${VERSION%.*}//./}: bad substitution > ``` > > Is the warning being displayed because $VERSION (=3.2.2) starts with a number? This is what I get for not trying these things. I think nesting the substitution like that isn't valid in bash, so maybe: SOVERSION=${VERSION%.*} ruby_PROVIDES="ruby_${SOVERSION//./}" actually works?