From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-044.btinternet.com (mailomta31-re.btinternet.com [213.120.69.124]) by sourceware.org (Postfix) with ESMTPS id 66DC43858D37 for ; Mon, 29 Apr 2024 19:37:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66DC43858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 66DC43858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=213.120.69.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714419426; cv=none; b=b2DvxzIGA/JuLNkSWL1fItwvvjQ05tXD+iGbJFVkDYpIcq8QYOpV4PykHl0xL+yMbkTdIm4ZVyy3jZ3lnf86F4QzZgrgrTkZGW19Dz2JUnTmQgEB39CsiQrEcF4gGuVMY1CFMs6gZDyWItQ84HfeL/Df96f0Ui7KYJ+WIgvxDuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714419426; c=relaxed/simple; bh=XiSDKtRjUSgXpPfdDX/vfJfPtmuWnzwLtSpKkH5vmUE=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=VL86xlILB1lBy9QOvIinbtNT8Sh3O8FHAzL062igR1lVNbUoUHrqEtTf8+hCSDYK8+2xdLWELDzYPg5fEUuTqau/9DSpJRxiAV0JAsJaZcw2SsbeG+TMldAWzqIiiuNwOrUdnCi+ITzgGjg2z/QH/tQ2G4TB4z0WTg6H3sEoAUc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from re-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.54.5]) by re-prd-fep-044.btinternet.com with ESMTP id <20240429193704.MCIF24338.re-prd-fep-044.btinternet.com@re-prd-rgout-002.btmx-prd.synchronoss.net>; Mon, 29 Apr 2024 20:37:04 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6577B5E31018E0CF X-Originating-IP: [86.140.112.82] X-OWM-Source-IP: 86.140.112.82 X-OWM-Env-Sender: jon.turney@dronecode.org.uk X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvledrvdduuddgudefkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhvegjtgfgsehtjeertddtvdejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeevvdekgfffteetueehgfdugefgkeevleejudduheevuedtveejfeevvdevvdfgvdenucfkphepkeeirddugedtrdduuddvrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtlegnpdhinhgvthepkeeirddugedtrdduuddvrdekvddpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepvehhrhhishhtihgrnhdrhfhrrghnkhgvsehtqdhonhhlihhnvgdruggvpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhmpdhrvghvkffrpehhohhsthekiedqudegtddqudduvddqkedvrdhrrghnghgvkeeiqddugedtrdgsthgtvghnthhrrghlphhluhhsrdgtohhmpdgruhhthhgpuhhsvghrpehjohhnthhurhhnvgihsegsthhi nhhtvghrnhgvthdrtghomhdpghgvohfkrfepifeupdfovfetjfhoshhtpehrvgdqphhrugdqrhhgohhuthdqtddtvd X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.109] (86.140.112.82) by re-prd-rgout-002.btmx-prd.synchronoss.net (authenticated as jonturney@btinternet.com) id 6577B5E31018E0CF; Mon, 29 Apr 2024 20:37:04 +0100 Message-ID: Date: Mon, 29 Apr 2024 20:37:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH cygport] Add customization support for announce command To: Christian Franke References: <2c21353b-f249-d03f-a9fa-68f0e56b9dcb@t-online.de> <20d64930-9c17-4fb0-861e-3145b5d67601@dronecode.org.uk> From: Jon Turney Content-Language: en-US Cc: cygwin-apps@cygwin.com In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/03/2024 16:33, Christian Franke via Cygwin-apps wrote: > Jon Turney wrote: >> On 23/02/2024 11:23, Christian Franke via Cygwin-apps wrote: >>> Christian Franke wrote: >>>> The email generated by the cygport announce command is useful, but >>>> actual use cases are somewhat limited due to the hard-coded email >>>> submission. >>>> >>>> The attached patch adds more flexibility. The patch is on top of the >>>> "Use correct wording if only one package is announced" patch. >>> >>> Slightly changed patch attached. Also adjusted to new version of "Use >>> correct wording if only one package is announced" patch. >>> >>> >> [...] >> >> Thanks for this. >> >>> Possible (better?) alternative names for the new settings: >>> ANNOUNCEMENT_EDITOR >>> ANNOUNCEMENT_MAILER >> >> Hmmm... I think "ANNOUNCE_EDITOR" and "ANNOUNCE_MAILER" would be >> the best for clarity and conciseness. > > New patch attached. Is still on top of "Use correct wording ..." patch. > > I also added HOMEPAGE to the propagated variables as this should be > included in an announcement. Thanks. > + /bin/bash -c "cd ${top} || exit 1 > +${HOMEPAGE+HOMEPAGE=${HOMEPAGE@Q}} > +P=${P@Q}; PF=${PF@Q}; PN=${PN@Q}; PR=${PR@Q}; PV=(${PV[*]@Q}) > +${SMTP_SENDER+SMTP_SENDER=${SMTP_SENDER@Q}} > +${SMTP_SERVER+SMTP_SERVER=${SMTP_SERVER@Q}} > +${SMTP_SERVER_PORT+SMTP_SERVER_PORT=${SMTP_SERVER_PORT@Q}} > +${SMTP_ENCRYPTION+SMTP_ENCRYPTION=${SMTP_ENCRYPTION@Q}} > +${SMTP_USER+SMTP_USER=${SMTP_USER@Q}} > +${SMTP_PASS+SMTP_PASS=${SMTP_PASS@Q}} > +${cmd} > +" $0 ${msg} || error "Command '\${${cmdvar}} ${msg}' (cwd=${top}) failed" > +} Sorry I didn't notice this before, and I am terrible at writing shell, but perhaps you could share the reasoning behind writing this as above, and not as, e.g. (cd ${top} && env BLAH ${cmd}) avoiding all the verbiage in the description of ANNOUNCE_EDITOR about it being fed into 'bash -c' (and hence getting evaluated twice??) rather than just run?