From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77016 invoked by alias); 29 Aug 2017 13:37:35 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 76051 invoked by uid 89); 29 Aug 2017 13:37:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Disclaimer, Hx-languages-length:1182, solver, turney X-HELO: limerock03.mail.cornell.edu Received: from limerock03.mail.cornell.edu (HELO limerock03.mail.cornell.edu) (128.84.13.243) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Aug 2017 13:37:24 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v7TDbMVE005406 for ; Tue, 29 Aug 2017 09:37:22 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v7TDbKYR014471 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 29 Aug 2017 09:37:21 -0400 Subject: Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP) To: cygwin-apps@cygwin.com References: <20170531105015.162228-1-jon.turney@dronecode.org.uk> From: Ken Brown Message-ID: Date: Tue, 29 Aug 2017 13:37:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170531105015.162228-1-jon.turney@dronecode.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00031.txt.bz2 On 5/31/2017 6:50 AM, Jon Turney wrote: > ... solve some problems, perhaps add some new ones, I guess. I'm not 100% > sure this is the right approach to take, but I wrote it, so here it is. [...] > - As implemented, selecting "Current" overrides "Keep". This is wrong, and a > change from current behaviour, but is probably a symptom of some deeper > confusion in the picker UI I'm not sure how to address I think the problem might be the following lines in the definition of SolverSolution::update: if (update) queue_push2(&job, SOLVER_UPDATE | SOLVER_SOLVABLE_ALL, 0); When the prerequisite checker calls SolverSolution::update, doesn't this cause the upgrading of old versions that we want to keep (assuming "Current" has been selected)? As a quick test, I commented out those lines and found that setup.exe let me keep an old version of a package. Maybe you need to add a DISABLE_UPDATE command to the solver task list to implement "Keep" for packages that would otherwise be updated. (Disclaimer: I have only looked briefly at the libsolv sources, so what I'm saying might be complete nonsense.) Ken