From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) by sourceware.org (Postfix) with ESMTPS id 59EBF3858D1E for ; Fri, 30 Sep 2022 18:38:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59EBF3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=SystematicSw.ab.ca Authentication-Results: sourceware.org; spf=none smtp.mailfrom=systematicsw.ab.ca Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id eEUQow65US8WreKtioB1UN; Fri, 30 Sep 2022 18:38:06 +0000 Received: from [10.0.0.5] ([184.64.124.72]) by cmsmtp with ESMTP id eKthomsdTlQu6eKthoz1pw; Fri, 30 Sep 2022 18:38:06 +0000 X-Authority-Analysis: v=2.4 cv=YfOuWidf c=1 sm=1 tr=0 ts=6337378e a=oHm12aVswOWz6TMtn9zYKg==:117 a=oHm12aVswOWz6TMtn9zYKg==:17 a=IkcTkHD0fZMA:10 a=TSbVqHtbAAAA:8 a=uYT-Tk0qkVT609LjNaIA:9 a=QEXdDO2ut3YA:10 a=NJcUIoPEKLAEIzHnl83t:22 Message-ID: Date: Fri, 30 Sep 2022 12:38:05 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Reply-To: Cygwin Applications Subject: Re: Issue with another downstream over DESTDIR builds Content-Language: en-CA To: Cygwin Applications References: <61bc8c6e-ed8f-a812-6c05-9e68c4a0a3c7@SystematicSw.ab.ca> <3436aa36-d661-629e-b704-b4887bb0b60f@SystematicSw.ab.ca> <5a2c3997-6274-59ce-fb1a-630418bc49f0@SystematicSw.ab.ca> <608B851A-90F3-4A75-BB9E-1F972934A995@sk2.org> <4ea3e2fe-a876-52b9-5f9a-f1da51017620@SystematicSw.ab.ca> <8f2b933a-06e3-d2bc-a552-6968147dc5d6@dronecode.org.uk> Cc: Brian.Inglis@SystematicSw.ab.ca From: Brian Inglis Organization: Systematic Software In-Reply-To: <8f2b933a-06e3-d2bc-a552-6968147dc5d6@dronecode.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfDsSsperkKifRWHaTKBKeVVtdsFbLbYTnv+T95cxX4oSykxbLBUERNq9WzTLKzcCYKa9qINPsj04BLTiNiWIKr5499+qb1m7kCim7amMIfXtKmc3asz5 rIC4pMOvpBnkLqhL8aEBietw702ZSJ06pru9GX5UZY9aAM0pu8diD4Pqvm0v8EDgkp0L6reJ0a3qCZsGR64XG1i4c0qdGbC/JDlnDgKTYVKVcwI9tt24QW6b /F25g9P6S6jKw6qDFeNg6Q== X-Spam-Status: No, score=-1162.5 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-09-30 06:11, Jon Turney wrote: > On 29/09/2022 20:15, Brian Inglis wrote: >> Hi folks, [Please Reply All to CC me as ISP blocking Cygwin lists] >> >> I previously submitted a patch upstream to add DESTDIR when creating >> package symlinks so cygport builds work without patches. >> >> Now another downstream is disputing that, requesting the patch be >> reverted, saying that symlink targets are contents and should always >> be from the non-DESTDIR native source as per GNU "rules" in the autobook. > A link to this discussion would be useful. Thanks Jon, Unfortunately the upstream package does not use a list so it is all DM. >> We agreed to request other more experienced opinions on this issue >> from our support groups and report back. >> >> I am asking the perhaps more experienced professional maintainers to >> provide their considered opinion on this issue, demonstrated by the >> reversion patch below. >> >>> The link's target must not include $(DESTDIR), otherwise this ends up >>> included in the shipped link. Linking the theoretical target gives the >>> correct result. >>> >>> --- a/Makefile.in >>> +++ b/Makefile.in >>> @@ -115,7 +115,7 @@ >>>        $(INSTALL_DATA) $(srcdir)/definitions.units >>> $(DESTDIR)@UDAT-DGkERpxY6iylqvY/pMPnfPU/3Eu2kcEP@public.gmane.org >>>        -rm -f $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>>        $(INSTALL_DATA) $(srcdir)/currency.units >>> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>> -    if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >>> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >>> +    if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >>> @CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >>>        $(INSTALL_DATA) $(srcdir)/locale_map.txt >>> $(DESTDIR)@UDAT@locale_map.txt >>>        if test $(HAVE_PYTHON) = yes; then \ >>>          $(INSTALL_PROGRAM) units_cur_inst $(DESTDIR)$(bindir)/`echo >>> units_cur|sed '$(transform)'`;fi > This patch looks correct. > > Think of it this way: --prefix etc. configures the location of the > installed files, DESTDIR selects a temporary staging directory that the > files are placed into (e.g. before packaging) > > So, targets of symlinks which are absolute paths should not contain > DESTDIR. I think I'll try and see what happens in cygport, report back here or for more feedback, and if no issues, okay with upstream. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in binary units and prefixes, physical quantities in SI.]