* Issue with another downstream over DESTDIR builds [not found] ` <608B851A-90F3-4A75-BB9E-1F972934A995@sk2.org> @ 2022-09-29 19:15 ` Brian Inglis 2022-09-30 12:11 ` Jon Turney 0 siblings, 1 reply; 4+ messages in thread From: Brian Inglis @ 2022-09-29 19:15 UTC (permalink / raw) To: Cygwin Applications; +Cc: Brian Inglis Hi folks, [Please Reply All to CC me as ISP blocking Cygwin lists] I previously submitted a patch upstream to add DESTDIR when creating package symlinks so cygport builds work without patches. Now another downstream is disputing that, requesting the patch be reverted, saying that symlink targets are contents and should always be from the non-DESTDIR native source as per GNU "rules" in the autobook. We agreed to request other more experienced opinions on this issue from our support groups and report back. I am asking the perhaps more experienced professional maintainers to provide their considered opinion on this issue, demonstrated by the reversion patch below. > The link's target must not include $(DESTDIR), otherwise this ends up > included in the shipped link. Linking the theoretical target gives the > correct result. > > --- a/Makefile.in > +++ b/Makefile.in > @@ -115,7 +115,7 @@ > $(INSTALL_DATA) $(srcdir)/definitions.units $(DESTDIR)@UDAT@definitions.units > -rm -f $(DESTDIR)@UDAT@currency.units > $(INSTALL_DATA) $(srcdir)/currency.units $(DESTDIR)@CDAT@currency.units > - if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf $(DESTDIR)@CDAT@currency.units $(DESTDIR)@UDAT@currency.units;fi > + if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf @CDAT@currency.units $(DESTDIR)@UDAT@currency.units;fi > $(INSTALL_DATA) $(srcdir)/locale_map.txt $(DESTDIR)@UDAT@locale_map.txt > if test $(HAVE_PYTHON) = yes; then \ > $(INSTALL_PROGRAM) units_cur_inst $(DESTDIR)$(bindir)/`echo units_cur|sed '$(transform)'`;fi -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in binary units and prefixes, physical quantities in SI.] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Issue with another downstream over DESTDIR builds 2022-09-29 19:15 ` Issue with another downstream over DESTDIR builds Brian Inglis @ 2022-09-30 12:11 ` Jon Turney 2022-09-30 18:38 ` Brian Inglis 0 siblings, 1 reply; 4+ messages in thread From: Jon Turney @ 2022-09-30 12:11 UTC (permalink / raw) To: cygwin-apps, Brian Inglis On 29/09/2022 20:15, Brian Inglis wrote: > Hi folks, [Please Reply All to CC me as ISP blocking Cygwin lists] > > I previously submitted a patch upstream to add DESTDIR when creating > package symlinks so cygport builds work without patches. > > Now another downstream is disputing that, requesting the patch be > reverted, saying that symlink targets are contents and should always be > from the non-DESTDIR native source as per GNU "rules" in the autobook. A link to this discussion would be useful. > We agreed to request other more experienced opinions on this issue from > our support groups and report back. > > I am asking the perhaps more experienced professional maintainers to > provide their considered opinion on this issue, demonstrated by the > reversion patch below. > >> The link's target must not include $(DESTDIR), otherwise this ends up >> included in the shipped link. Linking the theoretical target gives the >> correct result. >> >> --- a/Makefile.in >> +++ b/Makefile.in >> @@ -115,7 +115,7 @@ >> $(INSTALL_DATA) $(srcdir)/definitions.units >> $(DESTDIR)@UDAT-DGkERpxY6iylqvY/pMPnfPU/3Eu2kcEP@public.gmane.org >> -rm -f $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >> $(INSTALL_DATA) $(srcdir)/currency.units >> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >> - if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >> + if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >> @CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >> $(INSTALL_DATA) $(srcdir)/locale_map.txt >> $(DESTDIR)@UDAT@locale_map.txt >> if test $(HAVE_PYTHON) = yes; then \ >> $(INSTALL_PROGRAM) units_cur_inst $(DESTDIR)$(bindir)/`echo >> units_cur|sed '$(transform)'`;fi > This patch looks correct. Think of it this way: --prefix etc. configures the location of the installed files, DESTDIR selects a temporary staging directory that the files are placed into (e.g. before packaging) So, targets of symlinks which are absolute paths should not contain DESTDIR. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Issue with another downstream over DESTDIR builds 2022-09-30 12:11 ` Jon Turney @ 2022-09-30 18:38 ` Brian Inglis 2022-10-01 3:41 ` Brian Inglis 0 siblings, 1 reply; 4+ messages in thread From: Brian Inglis @ 2022-09-30 18:38 UTC (permalink / raw) To: Cygwin Applications; +Cc: Brian.Inglis On 2022-09-30 06:11, Jon Turney wrote: > On 29/09/2022 20:15, Brian Inglis wrote: >> Hi folks, [Please Reply All to CC me as ISP blocking Cygwin lists] >> >> I previously submitted a patch upstream to add DESTDIR when creating >> package symlinks so cygport builds work without patches. >> >> Now another downstream is disputing that, requesting the patch be >> reverted, saying that symlink targets are contents and should always >> be from the non-DESTDIR native source as per GNU "rules" in the autobook. > A link to this discussion would be useful. Thanks Jon, Unfortunately the upstream package does not use a list so it is all DM. >> We agreed to request other more experienced opinions on this issue >> from our support groups and report back. >> >> I am asking the perhaps more experienced professional maintainers to >> provide their considered opinion on this issue, demonstrated by the >> reversion patch below. >> >>> The link's target must not include $(DESTDIR), otherwise this ends up >>> included in the shipped link. Linking the theoretical target gives the >>> correct result. >>> >>> --- a/Makefile.in >>> +++ b/Makefile.in >>> @@ -115,7 +115,7 @@ >>> $(INSTALL_DATA) $(srcdir)/definitions.units >>> $(DESTDIR)@UDAT-DGkERpxY6iylqvY/pMPnfPU/3Eu2kcEP@public.gmane.org >>> -rm -f $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>> $(INSTALL_DATA) $(srcdir)/currency.units >>> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>> - if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >>> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >>> + if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >>> @CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >>> $(INSTALL_DATA) $(srcdir)/locale_map.txt >>> $(DESTDIR)@UDAT@locale_map.txt >>> if test $(HAVE_PYTHON) = yes; then \ >>> $(INSTALL_PROGRAM) units_cur_inst $(DESTDIR)$(bindir)/`echo >>> units_cur|sed '$(transform)'`;fi > This patch looks correct. > > Think of it this way: --prefix etc. configures the location of the > installed files, DESTDIR selects a temporary staging directory that the > files are placed into (e.g. before packaging) > > So, targets of symlinks which are absolute paths should not contain > DESTDIR. I think I'll try and see what happens in cygport, report back here or for more feedback, and if no issues, okay with upstream. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in binary units and prefixes, physical quantities in SI.] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Issue with another downstream over DESTDIR builds 2022-09-30 18:38 ` Brian Inglis @ 2022-10-01 3:41 ` Brian Inglis 0 siblings, 0 replies; 4+ messages in thread From: Brian Inglis @ 2022-10-01 3:41 UTC (permalink / raw) To: Cygwin Applications; +Cc: Brian.Inglis On 2022-09-30 12:38, Brian Inglis wrote: > On 2022-09-30 06:11, Jon Turney wrote: >> On 29/09/2022 20:15, Brian Inglis wrote: >>> Hi folks, [Please Reply All to CC me as ISP blocking Cygwin lists] >>> >>> I previously submitted a patch upstream to add DESTDIR when creating >>> package symlinks so cygport builds work without patches. >>> >>> Now another downstream is disputing that, requesting the patch be >>> reverted, saying that symlink targets are contents and should always >>> be from the non-DESTDIR native source as per GNU "rules" in the >>> autobook. > >> A link to this discussion would be useful. > > Thanks Jon, > > Unfortunately the upstream package does not use a list so it is all DM. > >>> We agreed to request other more experienced opinions on this issue >>> from our support groups and report back. >>> >>> I am asking the perhaps more experienced professional maintainers to >>> provide their considered opinion on this issue, demonstrated by the >>> reversion patch below. >>> >>>> The link's target must not include $(DESTDIR), otherwise this ends up >>>> included in the shipped link. Linking the theoretical target gives the >>>> correct result. >>>> >>>> --- a/Makefile.in >>>> +++ b/Makefile.in >>>> @@ -115,7 +115,7 @@ >>>> $(INSTALL_DATA) $(srcdir)/definitions.units >>>> $(DESTDIR)@UDAT-DGkERpxY6iylqvY/pMPnfPU/3Eu2kcEP@public.gmane.org >>>> -rm -f $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>>> $(INSTALL_DATA) $(srcdir)/currency.units >>>> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>>> - if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >>>> $(DESTDIR)@CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>>> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >>>> + if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf >>>> @CDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org >>>> $(DESTDIR)@UDAT-kLXayl1e/4yKtURqy47hLg@public.gmane.org;fi >>>> $(INSTALL_DATA) $(srcdir)/locale_map.txt >>>> $(DESTDIR)@UDAT@locale_map.txt >>>> if test $(HAVE_PYTHON) = yes; then \ >>>> $(INSTALL_PROGRAM) units_cur_inst $(DESTDIR)$(bindir)/`echo >>>> units_cur|sed '$(transform)'`;fi > >> This patch looks correct. >> >> Think of it this way: --prefix etc. configures the location of the >> installed files, DESTDIR selects a temporary staging directory that >> the files are placed into (e.g. before packaging) >> >> So, targets of symlinks which are absolute paths should not contain >> DESTDIR. > > I think I'll try and see what happens in cygport, report back here or > for more feedback, and if no issues, okay with upstream. Thanks Jon for your help, Tried builds with the upstream patch reversion, and all built okay locally and under CI, and install and run okay, so I admitted my mistake, agreed with their patch, and apologized to upstream and the other downstream for the noise and time wasted. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in binary units and prefixes, physical quantities in SI.] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-01 3:41 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <dd342dae-2c8d-e670-1921-5a091484eaf7@SystematicSw.ab.ca> [not found] ` <Ywf7Jezn6C7C0ANA@alpaca> [not found] ` <61bc8c6e-ed8f-a812-6c05-9e68c4a0a3c7@SystematicSw.ab.ca> [not found] ` <YwwQnK78duF8WCXk@alpaca> [not found] ` <3436aa36-d661-629e-b704-b4887bb0b60f@SystematicSw.ab.ca> [not found] ` <Yw1mwhOneVXk/tPy@alpaca> [not found] ` <b0bef636-e802-4be5-5b58-71f1ad555079@SystematicSw.ab.ca> [not found] ` <c2ccc61a-5189-ce02-e492-369c7885e4fb@SystematicSw.ab.ca> [not found] ` <YxlH9PpgiunNNTMc@alpaca> [not found] ` <5a2c3997-6274-59ce-fb1a-630418bc49f0@SystematicSw.ab.ca> [not found] ` <YxqNVUyGDzYGhuAb@alpaca> [not found] ` <608B851A-90F3-4A75-BB9E-1F972934A995@sk2.org> 2022-09-29 19:15 ` Issue with another downstream over DESTDIR builds Brian Inglis 2022-09-30 12:11 ` Jon Turney 2022-09-30 18:38 ` Brian Inglis 2022-10-01 3:41 ` Brian Inglis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).