public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: load_user_profile: chack if we got a valid, known domainname
Date: Thu, 28 Feb 2019 22:18:00 -0000 [thread overview]
Message-ID: <20190228221820.6960.qmail@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=5d9ac1291d84d6a6f15efe082d91ae1bf5947ab1
commit 5d9ac1291d84d6a6f15efe082d91ae1bf5947ab1
Author: Corinna Vinschen <corinna@vinschen.de>
Date: Thu Feb 28 23:17:55 2019 +0100
Cygwin: load_user_profile: chack if we got a valid, known domainname
...otherwise we may suffer a SEGV because dnsdomain is NULL.
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/cygwin/sec_auth.cc | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/winsup/cygwin/sec_auth.cc b/winsup/cygwin/sec_auth.cc
index a4e7458..c1667f5 100644
--- a/winsup/cygwin/sec_auth.cc
+++ b/winsup/cygwin/sec_auth.cc
@@ -288,17 +288,22 @@ load_user_profile (HANDLE token, struct passwd *pw, cygpsid &usersid)
break;
}
}
- if (cldap.fetch_ad_account (usersid, false, dnsdomain))
+ if (dnsdomain)
{
- PWCHAR val = cldap.get_profile_path ();
- if (val && *val)
+ if (cldap.fetch_ad_account (usersid, false, dnsdomain))
{
- wcsncpy (userpath, val, MAX_PATH - 1);
- userpath[MAX_PATH - 1] = L'\0';
- pi.lpProfilePath = userpath;
+ PWCHAR val = cldap.get_profile_path ();
+ if (val && *val)
+ {
+ wcsncpy (userpath, val, MAX_PATH - 1);
+ userpath[MAX_PATH - 1] = L'\0';
+ pi.lpProfilePath = userpath;
+ }
}
+ free (dnsdomain);
}
- free (dnsdomain);
+ else
+ debug_printf ("Unknown domain <%W>?", domain);
}
if (!LoadUserProfileW (token, &pi))
reply other threads:[~2019-02-28 22:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228221820.6960.qmail@sourceware.org \
--to=corinna@sourceware.org \
--cc=cygwin-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).