public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: authentication: Always initialize domain info Date: Fri, 01 Mar 2019 20:09:00 -0000 [thread overview] Message-ID: <20190301200935.68059.qmail@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=166913fb23dd7ac0c63976a2f4e40a9e44ca41ca commit 166913fb23dd7ac0c63976a2f4e40a9e44ca41ca Author: Corinna Vinschen <corinna@vinschen.de> Date: Fri Mar 1 21:08:09 2019 +0100 Cygwin: authentication: Always initialize domain info ...before calling any of its method. It's no safe bet that it's already initialized when calling s4uauth and adding it to load_user_profile certainly doesn't hurt. Signed-off-by: Corinna Vinschen <corinna@vinschen.de> Diff: --- winsup/cygwin/sec_auth.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/winsup/cygwin/sec_auth.cc b/winsup/cygwin/sec_auth.cc index ee740fa..2f04801 100644 --- a/winsup/cygwin/sec_auth.cc +++ b/winsup/cygwin/sec_auth.cc @@ -234,6 +234,10 @@ load_user_profile (HANDLE token, struct passwd *pw, cygpsid &usersid) WCHAR userpath[MAX_PATH]; PROFILEINFOW pi; + /* Initialize */ + if (!cygheap->dom.init ()) + return NULL; + extract_nt_dom_user (pw, domain, username); usersid.string (sid); debug_printf ("user: <%W> <%W> <%W>", username, domain, sid); @@ -1533,6 +1537,10 @@ s4uauth (bool logon, PCWSTR domain, PCWSTR user, NTSTATUS &ret_status) QUOTA_LIMITS quota; HANDLE token = NULL; + /* Initialize */ + if (!cygheap->dom.init ()) + return NULL; + push_self_privilege (SE_TCB_PRIVILEGE, true); if (logon)
reply other threads:[~2019-03-01 20:09 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190301200935.68059.qmail@sourceware.org \ --to=corinna@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).