From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7783 invoked by alias); 28 May 2019 20:15:33 -0000 Mailing-List: contact cygwin-cvs-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cygwin-cvs-owner@cygwin.com Received: (qmail 7606 invoked by uid 9996); 28 May 2019 20:15:24 -0000 Date: Tue, 28 May 2019 20:15:00 -0000 Message-ID: <20190528201524.7605.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Ken Brown To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: FIFO: respect the O_CLOEXEC flag X-Act-Checkin: newlib-cygwin X-Git-Author: Ken Brown X-Git-Refname: refs/heads/master X-Git-Oldrev: 5bb8d445f480ee344e81326d8387da0c4ef009c8 X-Git-Newrev: d79aa0f5939be2640b90971d022b98054b86d249 X-SW-Source: 2019-q2/txt/msg00063.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=d79aa0f5939be2640b90971d022b98054b86d249 commit d79aa0f5939be2640b90971d022b98054b86d249 Author: Ken Brown Date: Tue May 28 15:50:05 2019 -0400 Cygwin: FIFO: respect the O_CLOEXEC flag Set the inheritance of the Windows pipe handles according to the O_CLOEXEC flag. Previously the pipe was always created and opened with OBJ_INHERIT. Diff: --- winsup/cygwin/fhandler_fifo.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc index 3fabbc3..c9ff0a3 100644 --- a/winsup/cygwin/fhandler_fifo.cc +++ b/winsup/cygwin/fhandler_fifo.cc @@ -176,7 +176,7 @@ fhandler_fifo::create_pipe_instance (bool first) access = GENERIC_READ | FILE_READ_ATTRIBUTES | FILE_WRITE_ATTRIBUTES | SYNCHRONIZE; sharing = FILE_SHARE_READ | FILE_SHARE_WRITE; - hattr = OBJ_INHERIT; + hattr = openflags & O_CLOEXEC ? 0 : OBJ_INHERIT; if (first) hattr |= OBJ_CASE_INSENSITIVE; InitializeObjectAttributes (&attr, get_pipe_name (), @@ -209,7 +209,8 @@ fhandler_fifo::open_pipe (HANDLE& ph) if (!NT_SUCCESS (status)) return status; access = GENERIC_WRITE | SYNCHRONIZE; - InitializeObjectAttributes (&attr, get_pipe_name (), OBJ_INHERIT, + InitializeObjectAttributes (&attr, get_pipe_name (), + openflags & O_CLOEXEC ? 0 : OBJ_INHERIT, npfsh, NULL); sharing = FILE_SHARE_READ | FILE_SHARE_WRITE; status = NtOpenFile (&ph, access, &attr, &io, sharing, 0);