From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cygwin-cvs-return-14103-listarch-cygwin-cvs=sources.redhat.com@cygwin.com>
Received: (qmail 80278 invoked by alias); 27 Jun 2019 12:12:06 -0000
Mailing-List: contact cygwin-cvs-help@cygwin.com; run by ezmlm
Precedence: bulk
List-Id: <cygwin-cvs.cygwin.com>
List-Subscribe: <mailto:cygwin-cvs-subscribe@cygwin.com>
List-Post: <mailto:cygwin-cvs@cygwin.com>
List-Help: <mailto:cygwin-cvs-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-cvs-owner@cygwin.com
Received: (qmail 73826 invoked by uid 9996); 27 Jun 2019 12:11:56 -0000
Date: Thu, 27 Jun 2019 12:12:00 -0000
Message-ID: <20190627121156.73825.qmail@sourceware.org>
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Ken Brown <kbrown@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: honor the O_PATH flag when opening a FIFO
X-Act-Checkin: newlib-cygwin
X-Git-Author: Ken Brown <kbrown@cornell.edu>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: 739e89cbe6d0f416d9799e1c296d2d15d7fac4e5
X-Git-Newrev: aa55d22cb55d67d7f77ee9d58f9016c42c3ee495
X-SW-Source: 2019-q2/txt/msg00091.txt.bz2

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=aa55d22cb55d67d7f77ee9d58f9016c42c3ee495

commit aa55d22cb55d67d7f77ee9d58f9016c42c3ee495
Author: Ken Brown <kbrown@cornell.edu>
Date:   Thu Jun 27 07:46:14 2019 -0400

    Cygwin: honor the O_PATH flag when opening a FIFO
    
    Previously fhandler_fifo::open would treat the FIFO as a reader and
    would block, waiting for a writer.

Diff:
---
 winsup/cygwin/fhandler_fifo.cc | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_fifo.cc b/winsup/cygwin/fhandler_fifo.cc
index 737264b..92797ce 100644
--- a/winsup/cygwin/fhandler_fifo.cc
+++ b/winsup/cygwin/fhandler_fifo.cc
@@ -451,11 +451,18 @@ fhandler_fifo::open (int flags, mode_t)
    error_set_errno
   } res;
 
+  if (flags & O_PATH)
+    {
+      query_open (query_read_attributes);
+      nohandle (true);
+    }
+
   /* Determine what we're doing with this fhandler: reading, writing, both */
   switch (flags & O_ACCMODE)
     {
     case O_RDONLY:
-      reader = true;
+      if (!query_open ())
+	reader = true;
       break;
     case O_WRONLY:
       writer = true;
@@ -577,6 +584,8 @@ fhandler_fifo::open (int flags, mode_t)
 	    }
 	}
     }
+  if (query_open ())
+    res = success;
 out:
   if (res == error_set_errno)
     __seterrno ();