From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124380 invoked by alias); 16 Dec 2019 09:51:11 -0000 Mailing-List: contact cygwin-cvs-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cygwin-cvs-owner@cygwin.com Received: (qmail 124350 invoked by uid 9078); 16 Dec 2019 09:51:11 -0000 Date: Mon, 16 Dec 2019 09:51:00 -0000 Message-ID: <20191216095111.124348.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: ilogbl: Make sure to return FP_ILGB0 on zero input X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/master X-Git-Oldrev: b74ba7dca6489f5bb16048eb6bcddd5cd646c925 X-Git-Newrev: 29ba52da95532f61e2e15694245d5f25620e34b6 X-SW-Source: 2019-q4/txt/msg00035.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=29ba52da95532f61e2e15694245d5f25620e34b6 commit 29ba52da95532f61e2e15694245d5f25620e34b6 Author: Corinna Vinschen Date: Mon Dec 16 10:50:17 2019 +0100 Cygwin: ilogbl: Make sure to return FP_ILGB0 on zero input Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/math/ilogbl.S | 10 ++++++++++ winsup/cygwin/release/3.1.0 | 3 +++ 2 files changed, 13 insertions(+) diff --git a/winsup/cygwin/math/ilogbl.S b/winsup/cygwin/math/ilogbl.S index f68082c..a4fe503 100644 --- a/winsup/cygwin/math/ilogbl.S +++ b/winsup/cygwin/math/ilogbl.S @@ -23,6 +23,8 @@ __MINGW_USYMBOL(ilogbl): andb %ah, %dh cmpb $0x05, %dh je 1f /* Is +-Inf, jump. */ + cmpb $0x40, %dh + je 2f /* Is +-Inf, jump. */ fxtract pushq %rax @@ -37,6 +39,9 @@ __MINGW_USYMBOL(ilogbl): 1: fstp %st movl $0x7fffffff, %eax ret +2: fstp %st + movl $0x80000001, %eax /* FP_ILOGB0 */ + ret #else fldt 4(%esp) /* I added the following ugly construct because ilogb(+-Inf) is @@ -48,6 +53,8 @@ __MINGW_USYMBOL(ilogbl): andb %ah, %dh cmpb $0x05, %dh je 1f /* Is +-Inf, jump. */ + cmpb $0x40, %dh + je 2f /* Is +-Inf, jump. */ fxtract pushl %eax @@ -62,4 +69,7 @@ __MINGW_USYMBOL(ilogbl): 1: fstp %st movl $0x7fffffff, %eax ret +2: fstp %st + movl $0x80000001, %eax /* FP_ILOGB0 */ + ret #endif diff --git a/winsup/cygwin/release/3.1.0 b/winsup/cygwin/release/3.1.0 index b0e8456..681ea5d 100644 --- a/winsup/cygwin/release/3.1.0 +++ b/winsup/cygwin/release/3.1.0 @@ -108,3 +108,6 @@ Bug Fixes - Fix an assertion failure when /cygdrive contains an offline network drive. Addresses: https://cygwin.com/ml/cygwin/2019-12/msg00016.html + +- Fix return value of ilogbl for 0 input. + Addresses: https://cygwin.com/ml/cygwin/2019-12/msg00074.html