public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: pty: Remove close() call just before reopening slave.
Date: Thu, 23 Jan 2020 12:42:00 -0000	[thread overview]
Message-ID: <20200123124208.104113.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=5fdcb8fc135a14846cc37d30cb11d1590e5113b8

commit 5fdcb8fc135a14846cc37d30cb11d1590e5113b8
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Thu Jan 23 20:34:25 2020 +0900

    Cygwin: pty: Remove close() call just before reopening slave.
    
    - After commit da4ee7d60b9ff0bcdc081609a4467adb428d58e6, the issue
      reported in https://www.cygwin.com/ml/cygwin/2020-01/msg00209.html
      occurs. This patch fixes the issue.

Diff:
---
 winsup/cygwin/fhandler_tty.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 1710f25..4977a8b 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -1281,7 +1281,6 @@ fhandler_pty_slave::push_to_pcon_screenbuffer (const char *ptr, size_t len)
     {
       termios_printf ("GetConsoleMode failed, %E");
       /* Re-open handles */
-      this->close ();
       this->open (0, 0);
       /* Fix pseudo console window size */
       this->ioctl (TIOCSWINSZ, &get_ttyp ()->winsize);


                 reply	other threads:[~2020-01-23 12:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200123124208.104113.qmail@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).