From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12202 invoked by alias); 26 Feb 2020 20:13:25 -0000 Mailing-List: contact cygwin-cvs-help@cygwin.com; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cygwin-cvs-owner@cygwin.com Received: (qmail 12145 invoked by uid 9078); 26 Feb 2020 20:13:25 -0000 Date: Wed, 26 Feb 2020 20:13:00 -0000 Message-ID: <20200226201325.12143.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: cygserver: drop useless packed attribute X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/master X-Git-Oldrev: 5f66c2c756c2b3b43e565e471c82ee4ed05a4adb X-Git-Newrev: 0a37e9f0bc24c6d326816e6686c4eaa25b4fd83e X-SW-Source: 2020-q1/txt/msg00084.txt https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=0a37e9f0bc24c6d326816e6686c4eaa25b4fd83e commit 0a37e9f0bc24c6d326816e6686c4eaa25b4fd83e Author: Corinna Vinschen Date: Wed Feb 26 20:52:55 2020 +0100 Cygwin: cygserver: drop useless packed attribute ...from structs used for data exchange between clients and cygserver. All of the structs have the same size and member offsets, packed or unpacked. Keeping the packed attribute results in ominous warnings from gcc-9.2.0: cygserver.cc:259:10: warning: taking address of packed member of 'client_request_attach_tty::request_attach_tty' may result in an unaligned pointer value [-Waddress-of-packed-member] Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/cygserver.h | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/winsup/cygwin/cygserver.h b/winsup/cygwin/cygserver.h index 9de8c44..2788fa3 100644 --- a/winsup/cygwin/cygserver.h +++ b/winsup/cygwin/cygserver.h @@ -11,12 +11,6 @@ details. */ #ifndef _CYGSERVER_H_ #define _CYGSERVER_H_ -#ifdef __GNUC__ -#define CYGSERVER_PACKED __attribute__ ((packed)) -#else -#define CYGSERVER_PACKED -#endif - #define CYGWIN_SERVER_VERSION_MAJOR 1 #define CYGWIN_SERVER_VERSION_API 4 #define CYGWIN_SERVER_VERSION_MINOR 0 @@ -65,7 +59,7 @@ protected: header_t () {}; header_t (request_code_t, size_t); - } CYGSERVER_PACKED; + }; public: #ifndef __INSIDE_CYGWIN__ @@ -111,7 +105,7 @@ private: struct request_get_version { DWORD major, api, minor, patch; - } CYGSERVER_PACKED; + }; public: client_request_get_version (); @@ -156,7 +150,7 @@ private: { DWORD pid, master_pid; HANDLE from_master, to_master; - } CYGSERVER_PACKED; + }; public: #ifdef __INSIDE_CYGWIN__