public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: serial: wait for CancelIo completion
Date: Mon, 16 Mar 2020 09:20:30 +0000 (GMT)	[thread overview]
Message-ID: <20200316092030.0F7693861C56@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=7947581905637b837558ae9a2f1d35b8ab433e90

commit 7947581905637b837558ae9a2f1d35b8ab433e90
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Mon Mar 16 10:20:16 2020 +0100

    Cygwin: serial: wait for CancelIo completion
    
    Per https://devblogs.microsoft.com/oldnewthing/20110202-00/?p=11613
    GetOverlappedResult must be called blocking, waiting for the overlapped
    operation to complete.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler_serial.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_serial.cc b/winsup/cygwin/fhandler_serial.cc
index f92fc7039..f729765e0 100644
--- a/winsup/cygwin/fhandler_serial.cc
+++ b/winsup/cygwin/fhandler_serial.cc
@@ -135,7 +135,7 @@ fhandler_serial::raw_read (void *ptr, size_t& ulen)
 	     PurgeComm apparently discards in-flight bytes while CancelIo
 	     only stops the overlapped IO routine. */
 	  CancelIo (get_handle ());
-	  if (GetOverlappedResult (get_handle (), &io_status, &n, FALSE))
+	  if (GetOverlappedResult (get_handle (), &io_status, &n, TRUE))
 	    tot = n;
 	  else if (GetLastError () != ERROR_OPERATION_ABORTED)
 	    goto err;


                 reply	other threads:[~2020-03-16  9:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200316092030.0F7693861C56@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).