From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 7209E38930F7; Fri, 24 Apr 2020 14:23:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7209E38930F7 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: file I/O: make sure to treat write return value as ssize_t X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/master X-Git-Oldrev: 8a0bdd84b86e4c8c75a134fca05976e9494fef3f X-Git-Newrev: 5a7e130c31dfdf78f2e1b30dd6ec39a842be1336 Message-Id: <20200424142330.7209E38930F7@sourceware.org> Date: Fri, 24 Apr 2020 14:23:30 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 14:23:30 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=5a7e130c31dfdf78f2e1b30dd6ec39a842be1336 commit 5a7e130c31dfdf78f2e1b30dd6ec39a842be1336 Author: Corinna Vinschen Date: Fri Apr 24 16:14:43 2020 +0200 Cygwin: file I/O: make sure to treat write return value as ssize_t The return type of fhandler write methods is ssize_t. Don't use an int to store the return value, use ssize_t. Use ptrdiff_t for the buffer size. Signed-off-by: Corinna Vinschen Diff: --- winsup/cygwin/fhandler.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc index d754077b1..9d6271b3d 100644 --- a/winsup/cygwin/fhandler.cc +++ b/winsup/cygwin/fhandler.cc @@ -949,9 +949,9 @@ fhandler_base::write (const void *ptr, size_t len) } /* We've got a buffer-full, or we're out of data. Write it out */ - int nbytes; - int want = buf_ptr - buf; - if ((nbytes = raw_write (buf, want)) == want) + ssize_t nbytes; + ptrdiff_t want = buf_ptr - buf; + if ((nbytes = raw_write (buf, (size_t) want)) == want) { /* Keep track of how much written not counting additional \r's */ res = data - (char *)ptr;