public inbox for cygwin-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: cygwin-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: fifo: fix type of fifo_reader_id_t operators
Date: Fri,  8 May 2020 18:00:34 +0000 (GMT)	[thread overview]
Message-ID: <20200508180034.AEAFD3892003@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=2125ca8a69d0680ffe8079c15ef479f869ee35cc

commit 2125ca8a69d0680ffe8079c15ef479f869ee35cc
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Fri May 8 20:00:24 2020 +0200

    Cygwin: fifo: fix type of fifo_reader_id_t operators
    
    fifo_reader_id_t::operator == and != have been defined without type
    accidentally.  For some weird reason, only x86 gcc complains about
    this problem, not x86_64 gcc.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/fhandler.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/fhandler.h b/winsup/cygwin/fhandler.h
index 8a23d6753..9a82d491a 100644
--- a/winsup/cygwin/fhandler.h
+++ b/winsup/cygwin/fhandler.h
@@ -1308,12 +1308,12 @@ struct fifo_reader_id_t
 
   operator bool () const { return winpid != 0 || fh != NULL; }
 
-  friend operator == (const fifo_reader_id_t &l, const fifo_reader_id_t &r)
+  friend bool operator == (const fifo_reader_id_t &l, const fifo_reader_id_t &r)
   {
     return l.winpid == r.winpid && l.fh == r.fh;
   }
 
-  friend operator != (const fifo_reader_id_t &l, const fifo_reader_id_t &r)
+  friend bool operator != (const fifo_reader_id_t &l, const fifo_reader_id_t &r)
   {
     return l.winpid != r.winpid || l.fh != r.fh;
   }


                 reply	other threads:[~2020-05-08 18:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200508180034.AEAFD3892003@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=cygwin-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).