From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2210) id BED893870845; Thu, 28 May 2020 17:34:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BED893870845 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Ken Brown To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: stat: fix st_mode of fifos again X-Act-Checkin: newlib-cygwin X-Git-Author: Ken Brown X-Git-Refname: refs/heads/master X-Git-Oldrev: b5089f339a2124f52dfe58c8e3c929e4c5634175 X-Git-Newrev: 41ae84e6dcd810b9c94f1bbd5e00e6c8a28ccb94 Message-Id: <20200528173433.BED893870845@sourceware.org> Date: Thu, 28 May 2020 17:34:33 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2020 17:34:33 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=41ae84e6dcd810b9c94f1bbd5e00e6c8a28ccb94 commit 41ae84e6dcd810b9c94f1bbd5e00e6c8a28ccb94 Author: Ken Brown Date: Thu May 28 13:05:32 2020 -0400 Cygwin: stat: fix st_mode of fifos again This partially reverts commit f36262d56ac78f04de147746ce4a85c6155e4a23. That commit incorrectly made the st_mode of a fifo reflect the Windows permissions of the disk file underlying the fifo. Diff: --- winsup/cygwin/fhandler_disk_file.cc | 2 +- winsup/cygwin/release/3.1.5 | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_disk_file.cc b/winsup/cygwin/fhandler_disk_file.cc index 43d81c10f..c37b3c504 100644 --- a/winsup/cygwin/fhandler_disk_file.cc +++ b/winsup/cygwin/fhandler_disk_file.cc @@ -491,7 +491,7 @@ fhandler_base::fstat_helper (struct stat *buf) else { buf->st_dev = buf->st_rdev = dev (); - buf->st_mode |= dev ().mode () & S_IFMT; + buf->st_mode = dev ().mode (); buf->st_size = 0; } } diff --git a/winsup/cygwin/release/3.1.5 b/winsup/cygwin/release/3.1.5 index 1e3763f6c..0a78f5ff0 100644 --- a/winsup/cygwin/release/3.1.5 +++ b/winsup/cygwin/release/3.1.5 @@ -32,3 +32,6 @@ Bug Fixes: - Make sure pseudo tty doesn't hang if cygwin-console-helper.exe is non-functional. Addresses: https://cygwin.com/pipermail/cygwin-patches/2020q2/010191.html + +- Fix a bug causing FIFOs to have incorrect permissions. + Addresses: https://sourceware.org/pipermail/cygwin/2020-May/245031.html