public inbox for cygwin-cvs@sourceware.org help / color / mirror / Atom feed
From: Jon TURNEY <jturney@sourceware.org> To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: Make dumper scan more than first 4GB of VM on x86_64 Date: Sun, 12 Jul 2020 14:10:44 +0000 (GMT) [thread overview] Message-ID: <20200712141044.2C6123858D37@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=2a0e84c8dbe0dba5bd5f5ef652f61a1fd1e8d0fb commit 2a0e84c8dbe0dba5bd5f5ef652f61a1fd1e8d0fb Author: Jon Turney <jon.turney@dronecode.org.uk> Date: Wed Jul 1 14:00:53 2020 +0100 Cygwin: Make dumper scan more than first 4GB of VM on x86_64 It's unclear that we need an end address here at all, or can just rely on VirtualQueryEx() failing when we reach the end of memory regions. Diff: --- winsup/utils/dumper.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/winsup/utils/dumper.cc b/winsup/utils/dumper.cc index dcf01e800..ccc4bd12f 100644 --- a/winsup/utils/dumper.cc +++ b/winsup/utils/dumper.cc @@ -296,7 +296,7 @@ dumper::collect_memory_sections () return 0; LPBYTE current_page_address; - LPBYTE last_base = (LPBYTE) 0xFFFFFFFF; + LPBYTE last_base = (LPBYTE) -1; SIZE_T last_size = (SIZE_T) 0; SIZE_T done; @@ -307,7 +307,7 @@ dumper::collect_memory_sections () if (hProcess == NULL) return 0; - for (current_page_address = 0; current_page_address < (LPBYTE) 0xFFFF0000;) + for (current_page_address = 0; current_page_address < (LPBYTE) -1;) { if (!VirtualQueryEx (hProcess, current_page_address, &mbi, sizeof (mbi))) break;
reply other threads:[~2020-07-12 14:10 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200712141044.2C6123858D37@sourceware.org \ --to=jturney@sourceware.org \ --cc=cygwin-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).