From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2201) id 6C59A386F44A; Tue, 21 Jul 2020 14:20:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6C59A386F44A Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Jon TURNEY To: cygwin-cvs@sourceware.org Subject: [newlib-cygwin] Cygwin: Remove reading of PE for section flags from dumper X-Act-Checkin: newlib-cygwin X-Git-Author: Jon Turney X-Git-Refname: refs/heads/master X-Git-Oldrev: b40983eda166acf9741690cb49922b6c7255369b X-Git-Newrev: 0302c69164e5aac8b9c2dc03c70a2a23cfb6add4 Message-Id: <20200721142022.6C59A386F44A@sourceware.org> Date: Tue, 21 Jul 2020 14:20:22 +0000 (GMT) X-BeenThere: cygwin-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 14:20:22 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=0302c69164e5aac8b9c2dc03c70a2a23cfb6add4 commit 0302c69164e5aac8b9c2dc03c70a2a23cfb6add4 Author: Jon Turney Date: Sat Jul 4 15:51:14 2020 +0100 Cygwin: Remove reading of PE for section flags from dumper Diff: --- winsup/utils/Makefile.in | 6 +-- winsup/utils/dumper.cc | 2 - winsup/utils/dumper.h | 2 - winsup/utils/parse_pe.cc | 107 ----------------------------------------------- 4 files changed, 3 insertions(+), 114 deletions(-) diff --git a/winsup/utils/Makefile.in b/winsup/utils/Makefile.in index 5bb62bc6f..f9892fa1d 100644 --- a/winsup/utils/Makefile.in +++ b/winsup/utils/Makefile.in @@ -113,9 +113,9 @@ build_dumper := $(shell test -r "$(libbfd)" && echo 1) ifdef build_dumper CYGWIN_BINS += dumper.exe -dumper.o module_info.o parse_pe.o: CXXFLAGS += -I$(top_srcdir)/include -dumper.o parse_pe.o: dumper.h -dumper.exe: module_info.o parse_pe.o +dumper.o module_info.o: CXXFLAGS += -I$(top_srcdir)/include +dumper.o: dumper.h +dumper.exe: module_info.o dumper.exe: CYGWIN_LDFLAGS += -lpsapi -lbfd -lintl -liconv -liberty ${ZLIB} else all: warn_dumper diff --git a/winsup/utils/dumper.cc b/winsup/utils/dumper.cc index 46e4b0692..4577d2a3f 100644 --- a/winsup/utils/dumper.cc +++ b/winsup/utils/dumper.cc @@ -281,8 +281,6 @@ dumper::add_module (LPVOID base_address) new_entity->u.module.base_address = base_address; new_entity->u.module.name = module_name; - parse_pe (module_name, excl_list); - deb_printf ("added module %p %s\n", base_address, module_name); return 1; } diff --git a/winsup/utils/dumper.h b/winsup/utils/dumper.h index 9367587bf..78592b61e 100644 --- a/winsup/utils/dumper.h +++ b/winsup/utils/dumper.h @@ -133,8 +133,6 @@ extern int deb_printf ( const char* format, ... ); extern char* psapi_get_module_name ( HANDLE hProcess, LPVOID BaseAddress ); -extern int parse_pe ( const char* file_name, exclusion* excl_list ); - extern BOOL verbose; #endif diff --git a/winsup/utils/parse_pe.cc b/winsup/utils/parse_pe.cc deleted file mode 100644 index 90b5c0b0d..000000000 --- a/winsup/utils/parse_pe.cc +++ /dev/null @@ -1,107 +0,0 @@ -/* parse_pe.cc - - Written by Egor Duda - - This file is part of Cygwin. - - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License (file COPYING.dumper) for more details. - - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */ - -#define PACKAGE -#include -#include -#include - -#include "dumper.h" - -#ifndef bfd_get_section_size -#define bfd_get_section_size(sect) bfd_section_size(sect) -#endif - -int -exclusion::add (LPBYTE mem_base, SIZE_T mem_size) -{ - while (last >= size) - size += step; - region = (process_mem_region *) realloc (region, size * sizeof (process_mem_region)); - if (region == NULL) - return 0; - region[last].base = mem_base; - region[last].size = mem_size; - last++; - return 1; -}; - -int -cmp_regions (const void *r1, const void *r2) -{ - if (((process_mem_region *) r1)->base < ((process_mem_region *) r2)->base) - return -1; - if (((process_mem_region *) r1)->base > ((process_mem_region *) r2)->base) - return 1; - return 0; -} - -int -exclusion::sort_and_check () -{ - qsort (region, last, sizeof (process_mem_region), &cmp_regions); - for (process_mem_region * p = region; p < region + last - 1; p++) - { - process_mem_region *q = p + 1; - if (q == p + 1) - continue; - if (p->base + size > q->base) - { - fprintf (stderr, "region error @ (%p + %zd) > %p\n", p->base, size, q->base); - return 0; - } - } - return 1; -} - -static void -select_data_section (bfd * abfd, asection * sect, PTR obj) -{ - exclusion *excl_list = (exclusion *) obj; - - if ((sect->flags & (SEC_CODE | SEC_DEBUGGING)) && - sect->vma && bfd_get_section_size (sect)) - { - excl_list->add ((LPBYTE) sect->vma, (SIZE_T) bfd_get_section_size (sect)); - deb_printf ("excluding section: %20s %08lx\n", sect->name, - bfd_get_section_size (sect)); - } -} - -int -parse_pe (const char *file_name, exclusion * excl_list) -{ - if (file_name == NULL || excl_list == NULL) - return 0; - - bfd *abfd = bfd_openr (file_name, "pei-i386"); - if (abfd == NULL) - { - bfd_perror ("failed to open file"); - return 0; - } - - bfd_check_format (abfd, bfd_object); - bfd_map_over_sections (abfd, &select_data_section, (PTR) excl_list); - excl_list->sort_and_check (); - - bfd_close (abfd); - return 1; -}